Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node-fetch #321

Merged
merged 5 commits into from Jan 26, 2023
Merged

Add node-fetch #321

merged 5 commits into from Jan 26, 2023

Conversation

danmichaelo
Copy link
Contributor

@danmichaelo danmichaelo commented Jan 6, 2023

Fixes #305

Installed node-fetch 2.6.7, which is the same version used by @octokit/request:

npm ls node-fetch
github-script@6.3.3
├─┬ @octokit/core@3.6.0
│ └─┬ @octokit/request@5.6.3
│   └── node-fetch@2.6.7 deduped
└── node-fetch@2.6.7

The bundle size only increased from 772,787 to 772,991 bytes, so seems like re-use works well.

If we installed node-fetch 3 instead, the bundle size would increase to 1,045,047 bytes. Most likely the difference would hardly be noticeable, but on the other hand there aren't that many important improvements in node-fetch 3 as far as I'm aware, so perhaps it's still better to use node-fetch 2 to save 270 kB?

Of course, once Node18 is available from GitHub, node-fetch is no longer needed, but seems like that may take some time.

(Updated ncc because I had a build problem with node-fetch 3)

@danmichaelo danmichaelo requested a review from a team as a code owner January 6, 2023 23:55
@joshmgross joshmgross self-assigned this Jan 10, 2023
dist/37.index.js Outdated Show resolved Hide resolved
@joshmgross
Copy link
Member

Looks like the check-dist check is failing. Could you try re-running npm run build?

@joshmgross
Copy link
Member

Looks like the check-dist check is failing

Actually that's failing on main too, I'll investigate 🤔
https://github.com/actions/github-script/actions/runs/4011143550

@joshmgross
Copy link
Member

Thanks for your contribution! I'll go ahead and release a new version with this

@joshmgross joshmgross merged commit bcc3891 into actions:main Jan 26, 2023
@joshmgross joshmgross mentioned this pull request Jan 26, 2023
@joshmgross
Copy link
Member

This is now available in https://github.com/actions/github-script/releases/tag/v6.4.0

I'll update v6 tomorrow once I've validated that there are no unexpected issues.

fuxingloh pushed a commit to BirthdayResearch/jellyfishsdk that referenced this pull request Jan 31, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/github-script](https://togithub.com/actions/github-script) |
action | minor | `v6.3.3` -> `v6.4.0` |

---

### Release Notes

<details>
<summary>actions/github-script</summary>

###
[`v6.4.0`](https://togithub.com/actions/github-script/releases/tag/v6.4.0)

[Compare
Source](https://togithub.com/actions/github-script/compare/v6.3.3...v6.4.0)

##### What's Changed

- Bump json5 from 2.1.3 to 2.2.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/github-script#319
- Bump minimatch from 3.0.4 to 3.1.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/github-script#320
- Add node-fetch by
[@&#8203;danmichaelo](https://togithub.com/danmichaelo) in
[actions/github-script#321

##### New Contributors

- [@&#8203;jongwooo](https://togithub.com/jongwooo) made their first
contribution in
[actions/github-script#313
- [@&#8203;austinvazquez](https://togithub.com/austinvazquez) made their
first contribution in
[actions/github-script#306
- [@&#8203;danmichaelo](https://togithub.com/danmichaelo) made their
first contribution in
[actions/github-script#321

**Full Changelog**:
actions/github-script@v6.3.3...v6.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/JellyfishSDK/jellyfish).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTEuMSIsInVwZGF0ZWRJblZlciI6IjM0LjExMS4xIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
thedoublejay pushed a commit to levaintech/sticky that referenced this pull request Apr 10, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/github-script](https://togithub.com/actions/github-script) |
action | minor | `v6.3.3` -> `v6.4.1` |

---

### Release Notes

<details>
<summary>actions/github-script</summary>

###
[`v6.4.1`](https://togithub.com/actions/github-script/releases/tag/v6.4.1)

[Compare
Source](https://togithub.com/actions/github-script/compare/v6.4.0...v6.4.1)

#### What's Changed

- Add
[@&#8203;octokit/plugin-request-log](https://togithub.com/octokit/plugin-request-log),
to produce debug output for requests by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#358
- fix input handling by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#357
- Remove unused dependencies by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#356
- Default debug to current runner debug state by
[@&#8203;mjpieters](https://togithub.com/mjpieters) in
[actions/github-script#363

#### New Contributors

- [@&#8203;mjpieters](https://togithub.com/mjpieters) made their first
contribution in
[actions/github-script#358

**Full Changelog**:
actions/github-script@v6.4.0...v6.4.1

###
[`v6.4.0`](https://togithub.com/actions/github-script/releases/tag/v6.4.0)

[Compare
Source](https://togithub.com/actions/github-script/compare/v6.3.3...v6.4.0)

##### What's Changed

- Bump json5 from 2.1.3 to 2.2.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/github-script#319
- Bump minimatch from 3.0.4 to 3.1.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/github-script#320
- Add node-fetch by
[@&#8203;danmichaelo](https://togithub.com/danmichaelo) in
[actions/github-script#321

##### New Contributors

- [@&#8203;jongwooo](https://togithub.com/jongwooo) made their first
contribution in
[actions/github-script#313
- [@&#8203;austinvazquez](https://togithub.com/austinvazquez) made their
first contribution in
[actions/github-script#306
- [@&#8203;danmichaelo](https://togithub.com/danmichaelo) made their
first contribution in
[actions/github-script#321

**Full Changelog**:
actions/github-script@v6.3.3...v6.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/BirthdayResearch/sticky).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4zNC4xIiwidXBkYXRlZEluVmVyIjoiMzUuMzQuMSJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fetch parameter
2 participants