Add retry plugin and related options #288
Merged
+4,239
−2,993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshmgross
reviewed
Sep 23, 2022
joshmgross
approved these changes
Sep 23, 2022
src/retry-options.ts
Outdated
| retries | ||
| } | ||
|
|
||
| core.info( |
There was a problem hiding this comment.
Should this be debug?
Users might not want every step to output this information
|
@joshmgross what do you think about 6.3.0 since this is adding a feature, and not just a bug fix? |
👍 Sounds good to me |
joshmgross
approved these changes
Sep 26, 2022
fuxingloh
referenced
this pull request
in DeFiCh/metachain
Oct 12, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/github-script](https://togithub.com/actions/github-script) | action | minor | `v6.2.0` -> `v6.3.2` | --- ### Release Notes <details> <summary>actions/github-script</summary> ### [`v6.3.2`](https://togithub.com/actions/github-script/releases/tag/v6.3.2) [Compare Source](https://togithub.com/actions/github-script/compare/v6.3.1...v6.3.2) ##### What's Changed - Update [@​actions/core](https://togithub.com/actions/core) to 1.10.0 by [@​rentziass](https://togithub.com/rentziass) in [https://github.com/actions/github-script/pull/295](https://togithub.com/actions/github-script/pull/295) ##### New Contributors - [@​rentziass](https://togithub.com/rentziass) made their first contribution in [https://github.com/actions/github-script/pull/295](https://togithub.com/actions/github-script/pull/295) **Full Changelog**: actions/github-script@v6.3.1...v6.3.2 ### [`v6.3.1`](https://togithub.com/actions/github-script/releases/tag/v6.3.1) [Compare Source](https://togithub.com/actions/github-script/compare/v6.3.0...v6.3.1) #### What's Changed - Fix overriding request options from [@​actions/github](https://togithub.com/actions/github) by [@​luketomlinson](https://togithub.com/luketomlinson) in [https://github.com/actions/github-script/pull/293](https://togithub.com/actions/github-script/pull/293) **Full Changelog**: actions/github-script@v6.3.0...v6.3.1 ### [`v6.3.0`](https://togithub.com/actions/github-script/releases/tag/v6.3.0) [Compare Source](https://togithub.com/actions/github-script/compare/v6.2.0...v6.3.0) #### What's Changed - Add retry plugin and related options by [@​luketomlinson](https://togithub.com/luketomlinson) in [https://github.com/actions/github-script/pull/288](https://togithub.com/actions/github-script/pull/288), see https://github.com/actions/github-script/tree/v6.3.0#retries for more information. #### New Contributors - [@​luketomlinson](https://togithub.com/luketomlinson) made their first contribution in [https://github.com/actions/github-script/pull/288](https://togithub.com/actions/github-script/pull/288) **Full Changelog**: actions/github-script@v6.2.0...v6.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/DeFiCh/metachain). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTYuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIzMi4wIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few new features:
retries: the number of times to retry a failed requestretryAfter: a delay after retryingdoNotRetry: a list of HTTP status codes to NOT retryThese options largely mirror the options from the octokit plugin.
These options are completely opt in and require you to be explicit:
retryAfteranddoNotRetrywill have no effect unlessretriesis set.fixes #104