Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lockfileVersion in package-lock.json #136

Merged
merged 9 commits into from
Mar 2, 2022

Conversation

jtamsut
Copy link
Contributor

@jtamsut jtamsut commented Mar 1, 2022

This change addresses this issue.

Documentation for the semantics of lockfileVersion can be found here.

lockfileVersion: 2 is corresponds to an npm v7 (but is also backwards compatible with npm v5 and v6).

jtamsut added 2 commits March 1, 2022 13:14

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@jtamsut jtamsut requested a review from a team as a code owner March 1, 2022 21:15
@jtamsut jtamsut requested a review from konradpabjan March 1, 2022 21:15
jtamsut added 4 commits March 1, 2022 13:18

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Collaborator

@konradpabjan konradpabjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. You also need to bump up the version here and then CI should be green:

jtamsut added 3 commits March 1, 2022 14:30

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants