Fix the max comment length issue #767
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bteng22
requested changes
May 6, 2024
There was a problem hiding this comment.
Nice work around for the max length issue 👍 Did you need this PR merged for your demo? If not immediate, let's remove some of the duplication like you mentioned and add some tests for getMinSummaryForComment
Also is there a test repo you were running this against?
| ): Promise<void> { | ||
| const commentContent = summary.stringify() | ||
|
|
||
| core.setOutput('comment-content', commentContent) |
There was a problem hiding this comment.
Did we want to remove setting comment-content completely?
|
@jhutchings1 can I help get this merged? we're starting to see this happen with dependency-review frequently. |
|
This was enough to unblock my demos, but I would love for the team to take
this across the line if you have cycles. @bteng22, happy for an assist
here!
Justin Hutchings | Senior Director of Product Management | GitHub -
Security | <https://www.github.com/jhutchings1>
<https://www.linkedin.com/in/hutchingsjustin/>
<https://www.linkedin.com/in/hutchingsjustin/>
…On Wed, May 15, 2024 at 11:05 PM Cameron Cooper ***@***.***> wrote:
@jhutchings1 <https://github.com/jhutchings1> can I help get this merged?
we're starting to see this happen with dependency-review frequently.
—
Reply to this email directly, view it on GitHub
<#767 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADCCCIYSVZNBWD3OK26B7OLZCOBUTAVCNFSM6AAAAABHIFIIC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSHEZTQNRTGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into #730 in a demo I was building, so I threw together a quick fix for the issue. Now it'll generate a minimum comment. It's not super elegant (a bit of code duplication), but I was in a hurry to unblock the demo. I don't mind if the team decides to make some tweaks to make this less duplicative.
Fixes #730
