Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the v3 version of the deps.dev API #741

Merged
merged 5 commits into from May 10, 2024
Merged

Conversation

josieang
Copy link
Contributor

@josieang josieang commented Apr 9, 2024

While we (deps.dev) try to minimize breaking changes to v3alpha, it is experimental and will change from time to time. For stability, let's use the v3 API which does have stability guarantees (https://blog.deps.dev/api-v3/).

@josieang josieang requested a review from a team as a code owner April 9, 2024 06:13
@juxtin
Copy link
Contributor

juxtin commented Apr 9, 2024

Thanks for doing this, @josieang! This PR is currently failing in CI because it needs to be rebuilt, would you mind running npm run all and committing the result?

@josieang
Copy link
Contributor Author

Thanks! This should be done.

@juxtin
Copy link
Contributor

juxtin commented Apr 24, 2024

Hi @josieang, somehow we've ended up with a conflict in dist/index.js.map. Would you mind updating this PR from main and then running npm run all again?

@josieang
Copy link
Contributor Author

Just done. Thanks.

@josieang
Copy link
Contributor Author

josieang commented May 6, 2024

I've just updated it to main and I ran npm run all again. however I don't have permission to merge, @juxtin would you be able to merge this?

@josieang
Copy link
Contributor Author

josieang commented May 6, 2024

Apologies, I realise now I'm supposed to run npm install before running npm run build && np run package. Got a diff.

@elireisman elireisman merged commit 339e2e1 into actions:main May 10, 2024
6 checks passed
@josieang josieang deleted the deps-dev-v3 branch May 12, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants