-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dr Snaps launch PR #556
Merged
Merged
Dr Snaps launch PR #556
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
d35955e
Prototype re-try on snapshot warnings
hmaurer a4c5ac8
disable caching
hmaurer cff142b
includes_dependency_snapshots
hmaurer 9dde594
retry every 10s
hmaurer 90d3a94
fix
hmaurer a82096e
fix
hmaurer 1a326fc
proceed even if warnings
hmaurer 1644401
rewrite retry logic
hmaurer 66b6f67
Add configs
hmaurer 50954e6
fix
hmaurer f6f94a2
fix
hmaurer c3c3c2e
fix retry until
hmaurer 5573b58
better logging
hmaurer 1856a6d
fix
hmaurer d3fa764
fix
hmaurer ee86529
Show all non-empty snapshot warnings
juxtin abc80cf
Merge branch 'juxtin/snapshot-warnings' into juxtin/dr-snaps-pre-launch
juxtin ada1037
Merge remote-tracking branch 'origin/retry-on-snapshot-warnings' into…
juxtin e81e6e5
Default retry-on-snapshot-warnings to false
juxtin fcef41f
Add docs link to snapshot warnings
juxtin 726ffc8
Merge remote-tracking branch 'origin/main' into juxtin/dr-snaps-pre-l…
juxtin ffaf251
update dist
juxtin 7d0e0f6
Update src/dependency-graph.ts
febuiles 5e4b90e
add dist
febuiles c7e8727
Update action.yml
juxtin 07f52ce
Add example with retry-on-snapshot-warnings to docs
juxtin bb0ca79
Update action.yml to show retry default
juxtin File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Q) why do we do this instead of specifying an explicit type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess is that it's because this is just a wrapper function, so passing through the type as well as the value could simplify things when refactoring.