Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action fails to decorate PR when text is too long #730

Open
henriquevcosta opened this issue Mar 27, 2024 · 2 comments · May be fixed by #767
Open

Action fails to decorate PR when text is too long #730

henriquevcosta opened this issue Mar 27, 2024 · 2 comments · May be fixed by #767
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@henriquevcosta
Copy link

I just ran this action in a repo where the action failed with the error below and no content at all was posted to the workflow.

Would it be possible, in these cases, to leave a PR comment with the semantic of "The dependency review found new vulnerabilities in this change but was unable to display them here. You can see them in the output of the build here: <link to the action output/logs>" ? I know that a failed Check already has some of this semantic, but creating a comment provides a place to centralize discussion and clarity to developers.

Additionally, of course, maybe consider reviewing the output format to get more compact output in these cases by removing the "Scanned manifest files" section or trimming vulnerability descriptions to a fixed number of characters?

Warning: Unable to comment summary to pull-request, received error: Validation Failed: {"resource":"IssueComment","code":"unprocessable","field":"data","message":"Body is too long (maximum is 65536 characters)"}
@febuiles
Copy link
Contributor

@henriquevcosta thanks for the report. Can you post the configuration you're using for the Action?

@febuiles febuiles added the bug Something isn't working label Mar 27, 2024
@henriquevcosta
Copy link
Author

@febuiles Please see below. This is in a reusable workflow called from elsewhere, I've left the value of those inputs in comments.

    if: github.event_name == 'pull_request'
    steps:
      - name: Perform dependency review
        uses: actions/dependency-review-action@v4
        with:
          comment-summary-in-pr: on-failure
          license-check: false
          allow-ghsas: ${{ inputs.allow-ghsas }}  #  value: ''
          fail-on-severity: ${{ inputs.fail-severity }}  #  value: 'low'

@jovel jovel added the good first issue Good for newcomers label Mar 28, 2024
@jhutchings1 jhutchings1 linked a pull request May 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants