Dr Snaps launch PR #556
Merged
Dr Snaps launch PR #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… juxtin/dr-snaps-pre-launch
|
Dr Snaps sounds like a cool cartoon doctor. Also, thanks for pulling all this together @juxtin! ✨ |
Keeping this true by default means wasting actions minutes for the vast majority of DR users
juxtin
commented
Sep 6, 2023
Co-authored-by: Justin Holguín <juxtin@github.com>
febuiles
reviewed
Sep 7, 2023
febuiles
reviewed
Sep 7, 2023
| retryUntil: number | ||
| retryDelay: number | ||
| } | ||
| ): ReturnType<typeof dependencyGraph.compare> { |
There was a problem hiding this comment.
(Q) why do we do this instead of specifying an explicit type?
There was a problem hiding this comment.
My guess is that it's because this is just a wrapper function, so passing through the type as well as the value could simplify things when refactoring.
febuiles
approved these changes
Sep 7, 2023
Co-authored-by: Federico Builes <febuiles@github.com>
febuiles
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following prerequisites for the Dr Snaps launch:
retry-on-snapshot-warningsandretry-on-snapshot-warnings-timeoutconfig options, courtesy of @hmaurerretry-on-snapshot-warningstofalseby default.