Fix show-progress option #1466
Closed
Fix show-progress option #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spiritaine
approved these changes
Sep 5, 2023
Spiritaine
approved these changes
Sep 5, 2023
cory-miller
reviewed
Sep 5, 2023
| @@ -177,6 +177,7 @@ export async function getSource(settings: IGitSourceSettings): Promise<void> { | |||
| } else { | |||
| fetchOptions.fetchDepth = settings.fetchDepth | |||
| fetchOptions.fetchTags = settings.fetchTags | |||
| fetchOptions.showProgress = settings.showProgress | |||
There was a problem hiding this comment.
In v3 before this option was added it was applied to fetch-depth: 0 usage as well. Can you add this outside the if block, like on like 162?
|
Closing this PR as we have other one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix show-progress option by providing this option to fetch function