-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fail-on-cache-miss
option
#1036
Conversation
@kotewar I rebased all my PRs to resolve the merge conflicts and update the tests after the recent changes. Is there a timeline when this can move forward? It would be awesome if I wouldn't have to resolve merge conflicts every other week. |
Looks good to me, before we can release this out, we need a few additions
I'll approve, merge the PR and release the new version once the info is updated! Thanks :) |
This also please. Just one liner is enough. |
Sorry. Missed that the first time. Should be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Awesome 🎉 Thanks for your help getting it ready.
|
Let me check |
My bad, I forgot to tag the version to |
It works now! Thanks |
* Add fail-on-cache-miss option * Small improvements * Changes after rebase * Update description * Only fail if no cache entry is found * Code review * Update readme * Add additional test case * Bump version + changelog * Update package-lock.json * Update Readme
Description
Add an advanced option to fail job if cache miss occurs.
Based on the work from @kotewar which was reverted in 11ab7cc.
Motivation and Context
Fixes #955 and partially #1020 (comment)
This is already possible via the
cache-hit
output. However, especially for advanced workflows, this quickly becomes cumbersome to add every time. It's also an additional 3 line for each job and doesn't include a good error message.As mentioned in #955 (comment), the goal to simplify the configuration doesn't exclude the possibility to help with more advanced use cases. Including the new option will make it easier to use, help keep workflows more readable, and enable better error messages.
How Has This Been Tested?
Added test cases and run a test workflow using the feature branch.
Screenshots (if appropriate):
--
Types of changes
Checklist: