Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve output of check-dist workflow #521

Merged
merged 6 commits into from Mar 18, 2024
Merged

Conversation

camchenry
Copy link
Contributor

@camchenry camchenry commented Mar 18, 2024

This improves the error output when the dist directory contents do not match what was committed.

  • Adds the --text argument to git diff, which allows binary-like files like index.js to actually be rendered with full output, so you can see what changed in the CI output.
  • Adds the FILES_TO_IGNORE variable, so we can specify files that we don't care to diff.
  • Adds some helpful error output which should make it more clear what the error means and what to do.

Example error output:
image

Example success output:
image

@camchenry camchenry requested a review from a team as a code owner March 18, 2024 19:36
@camchenry camchenry added this pull request to the merge queue Mar 18, 2024
Merged via the queue into main with commit 2fc7325 Mar 18, 2024
5 checks passed
@camchenry camchenry deleted the camchenry/improve-check-dist branch March 18, 2024 19:58
bloopy-boi bot added a commit to h3mmy/bloopyboi that referenced this pull request Mar 19, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/add-to-project](https://togithub.com/actions/add-to-project)
| action | patch | `v0.6.0` -> `v0.6.1` |

---

### Release Notes

<details>
<summary>actions/add-to-project (actions/add-to-project)</summary>

###
[`v0.6.1`](https://togithub.com/actions/add-to-project/releases/tag/v0.6.1)

[Compare
Source](https://togithub.com/actions/add-to-project/compare/v0.6.0...v0.6.1)

#### What's Changed

- build(deps-dev): bump eslint-plugin-prettier from 5.0.0 to 5.1.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#514
- build(deps-dev): bump concurrently from 8.2.1 to 8.2.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#498
- build(deps-dev): bump eslint from 8.49.0 to 8.57.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#520
- build(deps): bump github/codeql-action from 2 to 3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#507
- build(deps): bump actions/upload-artifact from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#508
- Improve output of `check-dist` workflow by
[@&#8203;camchenry](https://togithub.com/camchenry) in
[actions/add-to-project#521
- build(deps): bump
[@&#8203;actions/core](https://togithub.com/actions/core) from 1.10.0 to
1.10.1 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#470
- build(deps): bump
[@&#8203;actions/github](https://togithub.com/actions/github) from 5.1.1
to 6.0.0 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#500
- build(deps): bump actions/setup-node from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#493
- Update readme and prepare release by
[@&#8203;talune](https://togithub.com/talune) in
[actions/add-to-project#523
- build(deps-dev): bump
[@&#8203;types/node](https://togithub.com/types/node) from 16.18.60 to
16.18.91 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#527
- build(deps-dev): bump eslint-plugin-jest from 27.6.0 to 27.9.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#525
- build(deps-dev): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 6.7.0 to 7.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#524
- build(deps-dev): bump typescript from 5.2.2 to 5.4.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#526

#### New Contributors

- [@&#8203;camchenry](https://togithub.com/camchenry) made their first
contribution in
[actions/add-to-project#521
- [@&#8203;talune](https://togithub.com/talune) made their first
contribution in
[actions/add-to-project#523

**Full Changelog**:
actions/add-to-project@v0.6.0...v0.6.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNTguMCIsInVwZGF0ZWRJblZlciI6IjM3LjI1OC4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2In0=-->

Co-authored-by: bloopy-boi[bot] <98279278+bloopy-boi[bot]@users.noreply.github.com>
kfcampbell pushed a commit to octokit/rest.js that referenced this pull request Mar 19, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/add-to-project](https://togithub.com/actions/add-to-project)
| action | patch | `v0.6.0` -> `v0.6.1` |

---

### Release Notes

<details>
<summary>actions/add-to-project (actions/add-to-project)</summary>

###
[`v0.6.1`](https://togithub.com/actions/add-to-project/releases/tag/v0.6.1)

[Compare
Source](https://togithub.com/actions/add-to-project/compare/v0.6.0...v0.6.1)

#### What's Changed

- build(deps-dev): bump eslint-plugin-prettier from 5.0.0 to 5.1.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#514
- build(deps-dev): bump concurrently from 8.2.1 to 8.2.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#498
- build(deps-dev): bump eslint from 8.49.0 to 8.57.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#520
- build(deps): bump github/codeql-action from 2 to 3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#507
- build(deps): bump actions/upload-artifact from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#508
- Improve output of `check-dist` workflow by
[@&#8203;camchenry](https://togithub.com/camchenry) in
[actions/add-to-project#521
- build(deps): bump
[@&#8203;actions/core](https://togithub.com/actions/core) from 1.10.0 to
1.10.1 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#470
- build(deps): bump
[@&#8203;actions/github](https://togithub.com/actions/github) from 5.1.1
to 6.0.0 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#500
- build(deps): bump actions/setup-node from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#493
- Update readme and prepare release by
[@&#8203;talune](https://togithub.com/talune) in
[actions/add-to-project#523
- build(deps-dev): bump
[@&#8203;types/node](https://togithub.com/types/node) from 16.18.60 to
16.18.91 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#527
- build(deps-dev): bump eslint-plugin-jest from 27.6.0 to 27.9.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#525
- build(deps-dev): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 6.7.0 to 7.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#524
- build(deps-dev): bump typescript from 5.2.2 to 5.4.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#526

#### New Contributors

- [@&#8203;camchenry](https://togithub.com/camchenry) made their first
contribution in
[actions/add-to-project#521
- [@&#8203;talune](https://togithub.com/talune) made their first
contribution in
[actions/add-to-project#523

**Full Changelog**:
actions/add-to-project@v0.6.0...v0.6.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/octokit/rest.js).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI0NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit to camunda/zeebe that referenced this pull request Mar 19, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/add-to-project](https://togithub.com/actions/add-to-project)
| action | patch | `v0.6.0` -> `v0.6.1` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>actions/add-to-project (actions/add-to-project)</summary>

###
[`v0.6.1`](https://togithub.com/actions/add-to-project/releases/tag/v0.6.1)

[Compare
Source](https://togithub.com/actions/add-to-project/compare/v0.6.0...v0.6.1)

#### What's Changed

- build(deps-dev): bump eslint-plugin-prettier from 5.0.0 to 5.1.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#514
- build(deps-dev): bump concurrently from 8.2.1 to 8.2.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#498
- build(deps-dev): bump eslint from 8.49.0 to 8.57.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#520
- build(deps): bump github/codeql-action from 2 to 3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#507
- build(deps): bump actions/upload-artifact from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#508
- Improve output of `check-dist` workflow by
[@&#8203;camchenry](https://togithub.com/camchenry) in
[actions/add-to-project#521
- build(deps): bump
[@&#8203;actions/core](https://togithub.com/actions/core) from 1.10.0 to
1.10.1 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#470
- build(deps): bump
[@&#8203;actions/github](https://togithub.com/actions/github) from 5.1.1
to 6.0.0 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#500
- build(deps): bump actions/setup-node from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#493
- Update readme and prepare release by
[@&#8203;talune](https://togithub.com/talune) in
[actions/add-to-project#523
- build(deps-dev): bump
[@&#8203;types/node](https://togithub.com/types/node) from 16.18.60 to
16.18.91 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#527
- build(deps-dev): bump eslint-plugin-jest from 27.6.0 to 27.9.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#525
- build(deps-dev): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 6.7.0 to 7.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#524
- build(deps-dev): bump typescript from 5.2.2 to 5.4.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[actions/add-to-project#526

#### New Contributors

- [@&#8203;camchenry](https://togithub.com/camchenry) made their first
contribution in
[actions/add-to-project#521
- [@&#8203;talune](https://togithub.com/talune) made their first
contribution in
[actions/add-to-project#523

**Full Changelog**:
actions/add-to-project@v0.6.0...v0.6.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 10pm every weekday,before 6am
every weekday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/camunda/zeebe).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI0NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants