Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set @types/node version to latest v16 release #373

Merged
merged 4 commits into from
May 8, 2023

Conversation

shiftkey
Copy link
Contributor

@shiftkey shiftkey commented May 8, 2023

Related to #372

This repository should only upgrade the @types/node package based on the versions supported by Actions. For now, let's leave this at node16 which is the version documented here:

runs:
using: 'node16'
main: 'dist/index.js'

@shiftkey shiftkey requested a review from a team as a code owner May 8, 2023 13:15
"version": "16.18.25",
"resolved": "https://registry.npmjs.org/@types/node/-/node-16.18.25.tgz",
"integrity": "sha512-rUDO6s9Q/El1R1I21HG4qw/LstTHCPO/oQNAwI/4b2f9EWvMnqt4d3HJwPMawfZ3UvodB8516Yg+VAq54YM+eA==",
"version": "16.11.68",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realised that this is going backwards (16.18.xx -> 16.11.xx) and it was down to me mis-reading the active releases page. Fixed in a42ffda

@shiftkey shiftkey merged commit 7c06a2e into main May 8, 2023
5 checks passed
@shiftkey shiftkey deleted the pin-node-version-to-v16 branch May 8, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants