Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gha-runner-scale-set-controller.chart instead of .Chart.Version #3729

Merged
merged 4 commits into from
Mar 10, 2025

Conversation

Mikey032
Copy link
Contributor

@Mikey032 Mikey032 commented Sep 4, 2024

Fixes #3728

@Mikey032
Copy link
Contributor Author

@mumoshu @rentziass @toast-gear can you have a look?

@madAndroid
Copy link

I've just hit this as well, would love to have it merged 🙏

madAndroid added a commit to madAndroid/actions-runner-controller that referenced this pull request Sep 20, 2024
@evilhamsterman
Copy link

This also solves #3772. This is a pretty big issue for some people with a pretty easy one line fix can some merge it soon?

@aubernknight
Copy link

When will this be approved it preventing us from deploying

@evilhamsterman
Copy link

@aubernknight I contacted GitHub support and the response is they won't, and that we should do it ourselves or pay them a ton of money to have their Professional Services show us how to fork the repo and merge a line

I've heard back from our engineering team and they let me know that, at the moment we do not support deploying ARC with either FluxCD or ArgoCD and this change is specific to those.

For the time being we encourage you to either manage your own charts or rely on the workaround you referenced.

and

While our teams are considering possible changes in this area for future releases, there are no plans to implement this change at this time.

You're welcome to make your own changes to customize these tools to better met your teams needs. If you'd like assistance from GitHub with those kinds of customizations I recommend you reach out to your GitHub account representative to discuss options. There are teams within GitHub, such as our Expert Services, that are best positioned to assist with these types of requests.

There's a work around in this comment that I've used #3728 (comment)

@nikola-jokic nikola-jokic self-requested a review as a code owner March 7, 2025 10:55
Co-authored-by: Nikola Jokic <jokicnikola07@gmail.com>
Copy link
Collaborator

@nikola-jokic nikola-jokic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikola-jokic nikola-jokic merged commit 75c6a94 into actions:master Mar 10, 2025
13 checks passed
@evilhamsterman
Copy link

@nikola-jokic THANK YOU!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to deploy gha-runner-scale-set-controller helm chart via Fluxcd
5 participants