-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gha-runner-scale-set-controller.chart instead of .Chart.Version #3729
Conversation
@mumoshu @rentziass @toast-gear can you have a look? |
I've just hit this as well, would love to have it merged 🙏 |
This also solves #3772. This is a pretty big issue for some people with a pretty easy one line fix can some merge it soon? |
d163111
to
757a935
Compare
When will this be approved it preventing us from deploying |
@aubernknight I contacted GitHub support and the response is they won't, and that we should do it ourselves or pay them a ton of money to have their Professional Services show us how to fork the repo and merge a line
and
There's a work around in this comment that I've used #3728 (comment) |
charts/gha-runner-scale-set-controller/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Nikola Jokic <jokicnikola07@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@nikola-jokic THANK YOU! |
Fixes #3728