This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Improve the multi-client implementation #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first iteration of the multi-client had two issues that are fixed in these changes: 1. The name SpecialConfigs was bad and has been renamed to APIGroupConfigs. 2. The scheme that was built out of the various clients wouldn't have worked in certain scenarios. These changes require the caller to pass a scheme that will work. Signed-off-by: Donnie Adams <donnie@acorn.io>
thedadams
requested review from
ibuildthecloud,
njhale,
StrongMonkey,
iwilltry42,
g-linville and
tylerslaton
| @@ -149,6 +149,9 @@ func (c *cacheClient) List(ctx context.Context, list kclient.ObjectList, opts .. | |||
| } | |||
|
|
|||
| func (c *cacheClient) Create(ctx context.Context, obj kclient.Object, opts ...kclient.CreateOption) error { | |||
| if u, ok := obj.(*uncached.Holder); ok { | |||
There was a problem hiding this comment.
What's the context for this change?
There was a problem hiding this comment.
It allows controllers to create, update, and delete resources without watching the GVK. That is, I want to delete an object without creating a trigger in baaah.
StrongMonkey
approved these changes
Jul 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first iteration of the multi-client had two issues that are fixed in these changes: