This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
fix: avoid concurrent map operations for valid owner changes #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
requested review from
njhale,
StrongMonkey,
iwilltry42,
keyallis,
g-linville and
tylerslaton
njhale
approved these changes
Feb 5, 2024
g-linville
reviewed
Feb 5, 2024
For controllers that themselves start other controllers, concurrent maps operations can happen when using the "valid owner change" feature. This change will get rid of these concurrent map operations by using a sync.Map instead. Signed-off-by: Donnie Adams <donnie@acorn.io>
thedadams
force-pushed
the
fix-concurrent-map-ops
branch
from
327c5a7
to
32d3918
Compare
g-linville
approved these changes
Feb 5, 2024
njhale
approved these changes
Feb 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For controllers that themselves start other controllers, concurrent maps operations can happen when using the "valid owner change" feature. This change will get rid of these concurrent map operations by using a sync.Map instead.