fix(WebSocketTransport): encode all query string params #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1286/bundle-report
Resolves an issue where the react-native websocket constructor crashes due to space characters being included in the ws url (in web and nodejs the websocket constructor will just url encode it automatically).
owenpearson
force-pushed
the
fix-ws-transport-param-encoding
branch
from
61ec742
to
52e94a4
Compare
lawrence-forooghian
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1262
Resolves an issue where the react-native websocket constructor crashes due to space characters being included in the ws url (in web and nodejs the websocket constructor will just url encode it automatically).