Remove ProtocolMessage.connectionKey
#1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library no longer uses this property; rather, it uses the property of the same name on ConnectionDetails. This property was removed from the features spec in [1]. This work was scheduled as part of ably-js v2, but I believe we can remove it in v1 given that ProtocolMessage is not part of the public API of the library (i.e. it doesn’t appear in ably.d.ts). Resolves #365. [1] ably/specification@2d5462c
Peter-Maguire
approved these changes
Apr 27, 2023
lawrence-forooghian
deleted the
365-remove-deprecated-ProtocolMessage-connectionKey
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library no longer uses this property; rather, it uses the property of the same name on
ConnectionDetails.This property was removed from the features spec in ably/specification@2d5462c.
This work was scheduled as part of ably-js v2, but I believe we can remove it in v1 given that
ProtocolMessageis not part of the public API of the library (i.e. it doesn’t appear inably.d.ts).Resolves #365.