Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTN20c: Retry connection attempt if 'online' while CONNECTING #1171

Merged
merged 3 commits into from Apr 4, 2023

Conversation

owenpearson
Copy link
Member

See ably/specification#136

Upon an 'online' event, if the connectionmanager state is CONNECTING, this will silently dispose of all pending transports and call startConnect again. All listeners are detached from the transports before disposal in order to prevent connection state side effects (otherwise the state will temporarily become DISCONNECTED).

@github-actions github-actions bot temporarily deployed to staging/pull/1171/features March 31, 2023 13:58 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1171/bundle-report March 31, 2023 14:00 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1171/typedoc March 31, 2023 14:00 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1171/features April 4, 2023 10:18 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1171/bundle-report April 4, 2023 10:19 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1171/typedoc April 4, 2023 10:19 Inactive
Copy link
Member

@SimonWoolf SimonWoolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 approved with one change request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants