Node/http: stop got from doing its own retries #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1122/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1122/typedoc
SimonWoolf
force-pushed
the
no-got-retries
branch
from
0799324
to
c066b75
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1122/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1122/typedoc
owenpearson
force-pushed
the
no-got-retries
branch
from
c066b75
to
a4a30bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got has an actually quite nice and configurable retry API.
But so do we, and having both stacking is definitely undesirable. Got's defaults aren't great (retrying 429s?); that's fixable, but we in any case prefer ours because we want to have retries go to fallback endpoints / other datacenters, which got can't do. So this disables got retries.
(Might be worth scanning through got docs to see if it's doing anything else overly-helpfully which we want to disable in favour of our own existing mechanisms)