Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from setuptools_scm_git_archive #1345

Merged
merged 2 commits into from Apr 11, 2024

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 24, 2023

I'm packaging this in nixpkgs and would like to avoid a dependency on setuptools_scm_git_archive. I followed the migration instructions and picked >= 7.0.5 because I saw that there was a bug reported in pypa/setuptools_scm#745 that was fixed in that version.

I do not know how to test this so help here is appreciated.

@abhinavsingh abhinavsingh added the bot:chronographer:skip PR using this label is exempted from CHANGELOG management label Aug 25, 2023
@abhinavsingh
Copy link
Owner

@tjni We may need to look a little deeper to remove this dependency. At least, as of now, our code tries to import proxy.common._scm_version and absence of this file will lead to errors. In fact, this integration was a contribution by @webknjaz , adding him for more insights here.

@webknjaz
Copy link
Contributor

The change is correct. The archival file should provide more metadata that newer versions of setuptools-scm use. As long as you don't need to support ancient Python versions that setuptools-scm no longer supports, this is good to go.

@abhinavsingh
Copy link
Owner

@webknjaz Thank you for your advice on this :). @tjni Back then workflows were broken and I had little bandwidth to invest into it. Today I have updated the develop branch so that workflows are stable again. Updated your branch, will try and merge once after workflow passes. Thank you folks.

@abhinavsingh abhinavsingh merged commit a8a7d7e into abhinavsingh:develop Apr 11, 2024
45 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip PR using this label is exempted from CHANGELOG management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants