Update to Python 3.12. #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also updates all dependencies and fixes the minor fallout of four MyPy typecheck issues (all instances of no support yet for @dataclass_transform: python/mypy#14293) and one Sphinx issue with the custom directive systems use of markdown.
sureshjoshi
reviewed
Oct 3, 2023
| version = "3.11.5" | ||
| # By default science ships as a "thin" scie that fetches CPython 3.11 on first run. | ||
| release = "20231002" | ||
| version = "3.12.0" |
There was a problem hiding this comment.
Not that it matters for this PR - but worth noting to anyone who uses Python 3.12 later.
https://github.com/indygreg/python-build-standalone/releases/tag/20231002
CPython 3.12.0 now supported. These distributions should be considered beta quality since it is their initial release and typically there are both upstream bugs and bugs in our packaging in the initial release. So exercise caution before deploying to production.
There was a problem hiding this comment.
Yeah. I wanted to get on the test train early - someone has to. CI (nox) fully dogfoods; so I'm confident science is still production ready for the next release.
sureshjoshi
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also updates all dependencies and fixes the minor fallout of four
MyPy typecheck issues (all instances of no support yet for
@dataclass_transform: python/mypy#14293) and
one Sphinx issue with the custom directive system's use of markdown.