Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to check documentation in review #123

Merged
merged 1 commit into from
May 13, 2024

Conversation

bwrsandman
Copy link
Contributor

@bwrsandman bwrsandman commented May 11, 2024

This PR attemps to give links to the review message so one can easily go read the documentation of the warning in question.

warning: missing username/bug in TODO [google-readability-todo]

// TODO(bwrsandman): Cause a clang-tidy error

Should now look like

warning: missing username/bug in TODO [google-readability-todo]

// TODO(bwrsandman): Cause a clang-tidy error

Proof of concept:
image

@bwrsandman bwrsandman force-pushed the links-in-comments branch 10 times, most recently from 8c41487 to 9bbd0b5 Compare May 11, 2024 04:40
@bwrsandman bwrsandman marked this pull request as ready for review May 11, 2024 04:53
Copy link
Owner

@ZedThree ZedThree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bwrsandman, this is really neat!

@ZedThree ZedThree merged commit 3ff13b4 into ZedThree:master May 13, 2024
1 check passed
@bwrsandman bwrsandman deleted the links-in-comments branch May 13, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants