write_xaiger: Detect and error on combinatorial loops #4898
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrystalDelusion
approved these changes
Mar 9, 2025
There was a problem hiding this comment.
If the same code is being used in both aiger.cc and xaiger.cc I wonder if it wouldn't be better for them to share the code instead of repeating it. But given how much of the code is already duplicated between the two I don't see any reason to block this PR on that basis.
Closed
KrystalDelusion
added
the
merge-soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix stack overflow in #4689 issue.
This is achieved by finding cycles in XAIG. The code was taken from aiger.cc.
This fix currently passes all yosys test, so I would suggest to test it with large combinational circuits.