Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: implement EIP-1559 #527

Open
wants to merge 60 commits into
base: dev-upgrade
Choose a base branch
from
Open

Conversation

gzliudan
Copy link
Collaborator

@gzliudan gzliudan commented Apr 25, 2024

Proposed changes

This PR is in progress now. Please don't merge it!!!

Implement below PRs for EIP-1559:

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@gzliudan gzliudan force-pushed the eip1559 branch 5 times, most recently from 0c6ae94 to c43f7d7 Compare April 29, 2024 12:06
@gzliudan gzliudan force-pushed the eip1559 branch 8 times, most recently from 3503cc8 to e79b8f7 Compare May 17, 2024 02:13
@gzliudan gzliudan changed the title implement EIP-1559 WIP: implement EIP-1559 May 17, 2024
@gzliudan gzliudan force-pushed the eip1559 branch 12 times, most recently from 214d35b to 57c2b1b Compare May 27, 2024 05:00
@gzliudan gzliudan force-pushed the eip1559 branch 4 times, most recently from a87d283 to d266cd7 Compare May 28, 2024 06:10
gzliudan and others added 29 commits May 31, 2024 17:15
This fixes a panic that occurs when HeaderByNumber() returns an error.
* Adjust pending nonce update operation

Benchmark the speed of transaction insertion under multiple accounts

core: fix rebase issues + docstring

core: make benchmark test use sync:ed method

* core: address review comments

* core: add memreport to benchmark

Co-authored-by: WeiLoy <wei_loy@163.com>
ethereum#24663)

This change removes extraneous/unnecessary checks for equality
when comparing 2 accessList values A and B. Given that we validate that
their lengths of A and B are equal, if so and if every element in A is
in B, reflexively every element in B is already in A. If that weren't
the case and an element g existed in A but not in B, that would mean
that there is an extra element and hence a mathematical contradiction.

Fixes ethereum#24658
Fix typo in txPool truncateQueue comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants