Removing more mining code: miningHashRate, isMining, startMining, stopMining #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks @franciscom0301 I got this though on the rd branch but I missed the double mining hash rate Let me add this in to the master, and then replicate on the rd branch as well, but will add to the master once I test since its blocking the lib build Thanks for finding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When linking xcash-core libs to x-cash wallet, compiler was unable to find the following mining functions:
Removing functions from wallet headers has solved the issue.
Type of change
How Has This Been Tested?
xcash-core was built and tested on the context of Android Wallet