Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterns Explorer: Makes the pagination items horizontally stacked on larger screens only #61776

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

amitraj2203
Copy link
Contributor

What?

Fixes: #61754

Why?

The current vertical stacking of pagination items in the Patterns Explorer doesn't make optimal use of available screen space. To address this, pagination items will now stack vertically only when the viewport is below 960px width. Beyond that, they will be horizontally aligned for better visibility.

How?

This PR adds a media query to change the flex-direction.

Testing Instructions

  1. Go to the post editor > Options > Preferences > Accessibility
  2. Enable the 'Show button text labels' preference.
  3. Close the preferences modal dialog and open the main inserter > Patterns
  4. Click 'Explore all patterns'
  5. Scroll the modal dialog at the bottom.
  6. Observe the pagination items.

Screenshots or screencast

demo.mov

Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: amitraj2203 <amitraj2203@git.wordpress.org>
Co-authored-by: afercia <afercia@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@amitraj2203
Copy link
Contributor Author

Additionally, I noticed that the same styles for pagination items are also being applied when we go to:

  1. Go to the post editor > Options > Preferences > Accessibility
  2. Enable the 'Show button text labels' preference.
  3. Close the preferences modal dialog and open the main inserter > Patterns
  4. Click 'All'
  5. Scroll the subsection to the bottom.
image

So I have added separate styles for this part which will keep these items vertically stacked at all viewports but for the modal one, the items will be stacked as per the viewport.

image

@amitraj2203
Copy link
Contributor Author

@WordPress/gutenberg-components Can you please review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patterns Explorer: Improve pagination layout when 'Show button text labels' preference is enabled
1 participant