-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an issue causing wp-scripts commands to fail if the file path contained a space character #61748
Conversation
…mmands would fail if the file path contained a space
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @kellenmace! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
I'm quite certain that this issue surfaced on our internal contributor day yesterday. When a few contributors attempted to generate and lint doc contributions for #60358, we kept getting odd ESLint reports that did not align with what we were seeing, or ESLint would just return nothing, which is assumed 'success', but there were still issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix. It would be perfectly fine to update to the more recent 10.x version or even 11.x, but it can be done separately.
Thank you! |
What?
Bump the
lint-staged
npm package to the next patch version to fix an issue wherewp-scripts
commands would fail if the file path contained a space.Fixes #42588
Why?
Before this fix, some wp-scripts commands would fail if the file path to the Gutenberg plugin contained one or more space characters. This issue was fixed in lint-staged v10.0.2. By bumping Gutenberg to that version, that issue is resolved.
How?
The
lint-staged
npm package has been bumped from version 10.0.1 to 10.0.2.Testing Instructions
Steps to reproduce the issue
gutenberg
plugin into a directory with a space character in its name.trunk
branch is checked out.lint-staged
version 10.0.1 is installed.npm install
.touch test-file.js && git add test-file.js
to create and stage a new file via git.git commit -m “Add test file”
to try to commit the change.Steps to test the bug fix
npm install
.lint-staged
version 10.0.2 is installed.touch test-file.js && git add test-file.js
to create and stage a new file via git.git commit -m “Add test file”
to try to commit the change.Testing Instructions for Keyboard
n/a