Editor: Polish the style of some of the post summary rows. #61645
+79
−166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +188 B (+0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
I still think Status is worth highlighting visually somehow, compared with other data points. But we can revisit that, so I'm happy to go with this.
Excerpt UX needs fine-tuning, which I appreciate may need to happen separately:
|
|
@jameskoster the excerpt is truncated to maximum 4 lines, that said, the truncate like that only works if the text is within a "block" element which means the "Edit" link can't be on the same line as the excerpt unless we remove the truncate. |
|
It can work if we truncate by character count and display inline-block. I had a draft PR here to achieve it, but perhaps that's not the best approach. Worst case scenario the 'Edit' button will need to live on it's own line beneath the excerpt, but my understanding is the dedicated button will be necessary. |
|
If I remember properly, truncating using characters like that is not something that we can do for i18n reasons. |
|
What's wrong with removing the truncate entirely? Why do we really need it? |
It's a guardrail against extremely long (manually added) excerpts dominating the sidebar. An edge case perhaps, but something to consider don't you think? If the inline button isn't feasible, it wouldn't be the end of the world to place the button immediately below the text: 
|
|
I applied the latest suggestion, let me know how it feels. |
jameskoster
approved these changes
May 15, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #59689
What?
This PR iterates towards the designs shared in #59689
It addresses the following points.
Testing Instructions