Scripts: Update webpack and related dependencies to the latest version #54657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Enhancement
|
Size Change: +4.68 kB (0%) Total Size: 1.63 MB
ℹ️ View Unchanged
|
gziolo
force-pushed
the
update/scripts-build-webpack
branch
from
63d5724
to
b013aa7
Compare
|
@desrosj, applying similar changes in the WordPress core would be great shortly before or even after Beta 1. |
gziolo
requested review from
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
gziolo
changed the title
gziolo
force-pushed
the
update/scripts-build-webpack
branch
from
b013aa7
to
6fb6f79
Compare
desrosj
added a commit
to desrosj/wordpress-develop
that referenced
this pull request
Sep 20, 2023
This includes Webpack and React related updates to accompany WordPress/gutenberg#54657.
|
I've created WordPress/wordpress-develop#5264 to accompany this change. Like this PR, there seems to be very minimal changes required, and there are no drastic changes to any built output. |
|
For the |
gziolo
requested review from
a team and
mcsf
and removed request for
a team
youknowriad
reviewed
Sep 21, 2023
| @@ -16,7 +16,7 @@ notMinified(); | |||
| exports[`ReadableJsAssetsWebpackPlugin should produce the expected output: Asset file index.min.js should match snapshot 1`] = `"console.log("hello");"`; | |||
|
|
|||
| exports[`ReadableJsAssetsWebpackPlugin should produce the expected output: Asset file view.js should match snapshot 1`] = ` | |||
| "/******/ (() => { // webpackBootstrap | |||
| "/******/ (function() { // webpackBootstrap | |||
There was a problem hiding this comment.
Weird, I though arrow support was good enough :P
There was a problem hiding this comment.
There might be a reason why webpack wraps code with a regular function now 🤷🏻
youknowriad
approved these changes
Sep 21, 2023
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Sep 21, 2023
…ersions. This updates the following npm dependencies: - `autoprefixer` to version `10.4.16`. - `grunt-contrib-qunit` to version `8.0.1`. - `postcss` to version `8.4.30`. - `react-refresh` to version `0.14.0`. - `sass` to version `1.68.0`. - `sinon` to version `16.0.0`. - `uuid` to version `9.0.1`. - `tslib` to version `2.6.2`. This change accompanies a similar one in the Gutenberg repository: WordPress/gutenberg#54657. Props gziolo, desrosj. Fixes #58863. git-svn-id: https://develop.svn.wordpress.org/trunk@56647 602fd350-edb4-49c9-b593-d223f7449a82
github-actions bot
pushed a commit
to gilzow/wordpress-performance
that referenced
this pull request
Sep 21, 2023
…ersions. This updates the following npm dependencies: - `autoprefixer` to version `10.4.16`. - `grunt-contrib-qunit` to version `8.0.1`. - `postcss` to version `8.4.30`. - `react-refresh` to version `0.14.0`. - `sass` to version `1.68.0`. - `sinon` to version `16.0.0`. - `uuid` to version `9.0.1`. - `tslib` to version `2.6.2`. This change accompanies a similar one in the Gutenberg repository: WordPress/gutenberg#54657. Props gziolo, desrosj. Fixes #58863. Built from https://develop.svn.wordpress.org/trunk@56647 git-svn-id: https://core.svn.wordpress.org/trunk@56159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Sep 21, 2023
…ersions. This updates the following npm dependencies: - `autoprefixer` to version `10.4.16`. - `grunt-contrib-qunit` to version `8.0.1`. - `postcss` to version `8.4.30`. - `react-refresh` to version `0.14.0`. - `sass` to version `1.68.0`. - `sinon` to version `16.0.0`. - `uuid` to version `9.0.1`. - `tslib` to version `2.6.2`. This change accompanies a similar one in the Gutenberg repository: WordPress/gutenberg#54657. Props gziolo, desrosj. Fixes #58863. Built from https://develop.svn.wordpress.org/trunk@56647 git-svn-id: http://core.svn.wordpress.org/trunk@56159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pereirinha
pushed a commit
to pereirinha/wordpress-develop
that referenced
this pull request
Sep 21, 2023
…ersions. This updates the following npm dependencies: - `autoprefixer` to version `10.4.16`. - `grunt-contrib-qunit` to version `8.0.1`. - `postcss` to version `8.4.30`. - `react-refresh` to version `0.14.0`. - `sass` to version `1.68.0`. - `sinon` to version `16.0.0`. - `uuid` to version `9.0.1`. - `tslib` to version `2.6.2`. This change accompanies a similar one in the Gutenberg repository: WordPress/gutenberg#54657. Props gziolo, desrosj. Fixes #58863. git-svn-id: https://develop.svn.wordpress.org/trunk@56647 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Let's bring webpack and related dependencies to the latest version and apply them to WordPress core around 6.4 Beta 1:
webpackupdated to the latest versionbrowserslistandcaniuse-liteupdated to the latest versionreact-refreshupdated to the latest versionIn addition, it tries to fix #53552 caused by the outdated version of
webpack-cli:Why?
How?
It brings
webpack-clito the latest version. There were some breaking changes in v5.0.0, but they don't seem to have impact like:--hotoption in favor of directly using theHotModuleReplacementplugin (only for build command, for serve it will work). I don't see the listed deprecated packages in the lock file anymore.There was a recent version bump enforced for the
webpackin the repository with #49075, so here we follow-up with another version bump that also gets applied to@wordpress/scripts.Testing Instructions
nvm useto switch to the currently supported Node.js and npm versions.npm installto install the latest version of dependencies.npm run buildand confirm the the build finishes correctly.npx wp-create-block example-static --no-wp-scriptsto confirm that Create Block still works.cd example-staticeto enter the newly created project.../node_modules/.bin/wp-scripts start --hotto confirm that you can develop blocks with the dev server.editfunction. See that the block gets automatically updated in the post editor after saving changes locally.Screenshots or screencast
I confirmed that React Fast Refresh still works with the updated
webpack-cliand other dependencies: