Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"@wordpress/scripts" seems to be incompatible with "node v20.x". #53213

Closed
stein2nd opened this issue Aug 1, 2023 · 6 comments · Fixed by #53629
Closed

"@wordpress/scripts" seems to be incompatible with "node v20.x". #53213

stein2nd opened this issue Aug 1, 2023 · 6 comments · Fixed by #53629
Assignees
Labels
[Package] ESLint plugin /packages/eslint-plugin [Package] Scripts /packages/scripts [Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@stein2nd
Copy link

stein2nd commented Aug 1, 2023

Description

I report that I ran "npm install @wordpress/scripts --save-dev" and got the following WARN.:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: 'eslint-plugin-jsdoc@39.9.1',
npm WARN EBADENGINE required: { node: '^14 || ^16 || ^17 || ^18 || ^19' },
npm WARN EBADENGINE current: { node: 'v20.5.0', npm: '9.8.0' }
npm WARN EBADENGINE }

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: '@es-joy/jsdoccomment@0.36.1',
npm WARN EBADENGINE required: { node: '^14 || ^16 || ^17 || ^18 || ^19' },
npm WARN EBADENGINE current: { node: 'v20.5.0', npm: '9.8.0' }
npm WARN EBADENGINE }

npm WARN deprecated stable@0.1.8: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility

When I ran "npm install -D eslint eslint-plugin-jsdoc @es-joy/jsdoccomment" individually, no warn showed up.

Step-by-step reproduction instructions

  1. Using Terminal, run "npm install -D @wordpress/scripts".

Screenshots, screen recording, code snippet

image

image

image

No response

Environment info

  • Device: macOS Ventura 13.5

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No

@jordesign jordesign added [Type] Bug An existing feature does not function as intended Needs Testing Needs further testing to be confirmed. npm Packages Related to npm packages labels Aug 1, 2023
@stein2nd
Copy link
Author

stein2nd commented Aug 2, 2023

Additional information (2023-08-02 11:47 JST).

  • Below are the versions of "eslint-plugin-jsdoc" and "@es-joy/jsdoccomment" when installed individually:

    • eslint-plugin-jsdoc: 46.4.5
    • @es-joy/jsdoccomment: 0.39.4
  • The following is the result of running "npm ls stable":

    • └─┬ @wordpress/scripts@26.9.0
      • └─┬ @svgr/webpack@6.5.1
        • └─┬ @svgr/plugin-svgo@6.5.1
          • └─┬ svgo@2.8.0
            • └── stable@0.1.8

@stein2nd
Copy link
Author

stein2nd commented Aug 2, 2023

When svgo@3.0.2 was installed separately, the "deprecated stable@0.1.8" warning did not appear.

In other words, maybe @wordpress/scripts should install @svgr/webpack@8.0.1 instead of @svgr/webpack@6.2.1.

@stein2nd
Copy link
Author

stein2nd commented Aug 2, 2023

  • The following is the result of running "npm ls eslint-plugin-jsdoc":

    • ├─┬ @wordpress/scripts@26.9.0
      • │ └─┬ @wordpress/eslint-plugin@14.11.0
        • │ └── eslint-plugin-jsdoc@39.9.1
    • └── eslint-plugin-jsdoc@46.4.5 <- manual installed
  • Next, the following is the result of running "npm ls @es-joy/jsdoccomment":

    • ├── @es-joy/jsdoccomment@0.39.4 <- manual installed
    • ├─┬ @wordpress/scripts@26.9.0
      • │ └─┬ @wordpress/eslint-plugin@14.11.0
        • │ └─┬ eslint-plugin-jsdoc@39.9.1
          • │ └── @es-joy/jsdoccomment@0.36.1
    • └─┬ eslint-plugin-jsdoc@46.4.5 <- manual installed
      • └── @es-joy/jsdoccomment@0.39.4 deduped

Therefore, maybe @wordpress/eslint-plugin should install eslint-plugin-jsdoc@46.4.5 instead of eslint-plugin-jsdoc@39.6.9.

@gziolo gziolo added [Package] Scripts /packages/scripts [Package] ESLint plugin /packages/eslint-plugin and removed npm Packages Related to npm packages labels Aug 4, 2023
@mikeybinns
Copy link
Contributor

mikeybinns commented Aug 10, 2023

I am also running into this issue with @es-joy/jsdoccomment, and it seems like eslint-plugin-jsdoc in eslint-plugin is the way to fix it for me

@gziolo
Copy link
Member

gziolo commented Aug 14, 2023

I opened #53629 which tries to fix the issue with eslint-plugin-jsdoc.

@gziolo gziolo self-assigned this Aug 14, 2023
@gziolo gziolo added [Status] In Progress Tracking issues with work in progress and removed Needs Testing Needs further testing to be confirmed. labels Aug 14, 2023
@gziolo
Copy link
Member

gziolo commented Aug 14, 2023

I also opened #53630 to see what's required to get rid of the deprecated stable@0.1.8 deep dependency.

@gziolo gziolo added the [Priority] High Used to indicate top priority items that need quick attention label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] ESLint plugin /packages/eslint-plugin [Package] Scripts /packages/scripts [Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants