Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@wordpress/scripts@26.10.0 has deprecated NPM modules and unsupported node v.20.5.0 #53553

Closed
stein2nd opened this issue Aug 11, 2023 · 3 comments · Fixed by #53629
Closed

@wordpress/scripts@26.10.0 has deprecated NPM modules and unsupported node v.20.5.0 #53553

stein2nd opened this issue Aug 11, 2023 · 3 comments · Fixed by #53629
Labels
[Package] Scripts /packages/scripts [Priority] High Used to indicate top priority items that need quick attention [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended

Comments

@stein2nd
Copy link

stein2nd commented Aug 11, 2023

Description

When ncu was executed, @wordpress/scripts was displayed as ^26.9.0 → ^26.10.0, so ncu -u npm install was executed in sequence.
As a result, several npm modules were shown as deprecated as follows:

npm WARN deprecated stable@0.1.8: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: 'eslint-plugin-jsdoc@39.9.1',
npm WARN EBADENGINE required: { node: '^14 || ^16 || ^17 || ^18 || ^19' },
npm WARN EBADENGINE current: { node: 'v20.5.0', npm: '9.8.0' }
npm WARN EBADENGINE }

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: '@es-joy/jsdoccomment@0.36.1',
npm WARN EBADENGINE required: { node: '^14 || ^16 || ^17 || ^18 || ^19' },
npm WARN EBADENGINE current: { node: 'v20.5.0', npm: '9.8.0' }
npm WARN EBADENGINE }

This issue appears to be due to the same cause as 53213 reported under 26.9.0.

Step-by-step reproduction instructions

  1. ncu
  2. ncu -u
  3. npm install

Screenshots, screen recording, code snippet

image

image

image

Environment info

System:

  • OS: macOS 13.5
  • CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
  • Memory: 531.77 MB / 32.00 GB
  • Shell: 3.2.57 - /bin/bash

Binaries:

  • Node: 20.5.0 - ~/.nodebrew/current/bin/node
  • Yarn: 1.22.19 - /usr/local/bin/yarn
  • npm: 9.8.0 - ~/.nodebrew/current/bin/npm

npmPackages:

  • @wordpress/scripts: ^26.10.0 => 26.10.0

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@stein2nd stein2nd changed the title @wordpress/scripts@26.10.0 has some deprecated NPM modules @wordpress/scripts@26.10.0 has deprecated NPM modules and unsupported node v.20.5.0 Aug 11, 2023
@gziolo gziolo added [Type] Bug An existing feature does not function as intended [Priority] High Used to indicate top priority items that need quick attention [Package] Scripts /packages/scripts Needs Dev Ready for, and needs developer efforts labels Aug 11, 2023
@gziolo
Copy link
Member

gziolo commented Aug 14, 2023

I opened #53629 which tries to fix the issue with eslint-plugin-jsdoc.

@gziolo gziolo added [Status] In Progress Tracking issues with work in progress and removed Needs Dev Ready for, and needs developer efforts labels Aug 14, 2023
@gziolo gziolo self-assigned this Aug 14, 2023
@gziolo
Copy link
Member

gziolo commented Aug 14, 2023

I also opened #53630 to see what's required to get rid of the deprecated stable@0.1.8 deep dependency.

@gziolo gziolo added the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label Aug 14, 2023
@gziolo gziolo removed their assignment Aug 14, 2023
@gziolo gziolo removed the [Status] In Progress Tracking issues with work in progress label Aug 14, 2023
@gziolo
Copy link
Member

gziolo commented Aug 14, 2023

Actually, closing it as duplicate of #53629.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Scripts /packages/scripts [Priority] High Used to indicate top priority items that need quick attention [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants