Try: allow multiple attribute to be a string in upload components (#…

…53350) * Update MediaPlaceholder docs to include add * Update FormFileUpload types to allow strings for multiple prop * Update FormFIleUpload and MediaUpload readme files * Revert addition of string type for FormFileUpload * Revert additional FormFileUpload type comments * Ensure multiple is boolean * Ensure multiple is boolean in media placeholder component * Ensure multiple is a boolean in media replace flow component
WordPress · Sep 6, 2023 · 7924ef1 · 7924ef1
1 parent 97ccdb6
commit 7924ef1
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/packages/block-editor/src/components/media-placeholder/README.md b/packages/block-editor/src/components/media-placeholder/README.md
@@ -133,9 +133,9 @@ An object that can contain a `title` and `instructions` properties. These proper
 
 ### multiple
 
-Whether to allow multiple selection of files or not.
+Whether to allow multiple selection of files or not. This property will also accept a string with the value `add` to allow multiple selection of files without the need to use the `Shift` or `Ctrl`/`Cmd` keys.
 
--   Type: `Boolean`
+-   Type: `Boolean|String`
 -   Required: No
 -   Default: `false`
 -   Platform: Web

diff --git a/packages/block-editor/src/components/media-placeholder/index.js b/packages/block-editor/src/components/media-placeholder/index.js
@@ -469,7 +469,7 @@ export function MediaPlaceholder( {
 					<FormFileUpload
 						onChange={ onUpload }
 						accept={ accept }
-						multiple={ multiple }
+						multiple={ !! multiple }
 						render={ ( { openFileDialog } ) => {
 							const content = (
 								<>
@@ -508,7 +508,7 @@ export function MediaPlaceholder( {
 						) }
 						onChange={ onUpload }
 						accept={ accept }
-						multiple={ multiple }
+						multiple={ !! multiple }
 					>
 						{ __( 'Upload' ) }
 					</FormFileUpload>

diff --git a/packages/block-editor/src/components/media-replace-flow/index.js b/packages/block-editor/src/components/media-replace-flow/index.js
@@ -179,7 +179,7 @@ const MediaReplaceFlow = ( {
 									uploadFiles( event, onClose );
 								} }
 								accept={ accept }
-								multiple={ multiple }
+								multiple={ !! multiple }
 								render={ ( { openFileDialog } ) => {
 									return (
 										<MenuItem

diff --git a/packages/block-editor/src/components/media-upload/README.md b/packages/block-editor/src/components/media-upload/README.md
@@ -72,11 +72,12 @@ Value of Frame content default mode like 'browse', 'upload' etc.
 -   Required: No
 -   Default: false
 -   Platform: Web
+
 ### multiple
 
-Whether to allow multiple selections or not.
+Whether to allow multiple selection of files or not. This property will also accept a string with the value `add` to allow multiple selection of files without the need to use the `Shift` or `Ctrl`/`Cmd` keys.
 
--   Type: `Boolean`
+-   Type: `Boolean|String`
 -   Required: No
 -   Default: false
 -   Platform: Web