Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency urllib3 to v2.2.0 #2055

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 13, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
urllib3 (changelog) ==2.0.7 -> ==2.2.0 age adoption passing confidence

Release Notes

urllib3/urllib3 (urllib3)

v2.2.0

Compare Source

==================

  • Added support for Emscripten and Pyodide <https://urllib3.readthedocs.io/en/latest/reference/contrib/emscripten.html>, including streaming support in cross-origin isolated browser environments where threading is enabled. (#&#8203;2951 <https://github.com/urllib3/urllib3/issues/2951>)
  • Added support for HTTPResponse.read1() method. (#&#8203;3186 <https://github.com/urllib3/urllib3/issues/3186>__)
  • Added rudimentary support for HTTP/2. (#&#8203;3284 <https://github.com/urllib3/urllib3/issues/3284>__)
  • Fixed issue where requests against urls with trailing dots were failing due to SSL errors
    when using proxy. (#&#8203;2244 <https://github.com/urllib3/urllib3/issues/2244>__)
  • Fixed HTTPConnection.proxy_is_verified and HTTPSConnection.proxy_is_verified
    to be always set to a boolean after connecting to a proxy. It could be
    None in some cases previously. (#&#8203;3130 <https://github.com/urllib3/urllib3/issues/3130>__)
  • Fixed an issue where headers passed in a request with json= would be mutated (#&#8203;3203 <https://github.com/urllib3/urllib3/issues/3203>__)
  • Fixed HTTPSConnection.is_verified to be set to False when connecting
    from a HTTPS proxy to an HTTP target. It was set to True previously. (#&#8203;3267 <https://github.com/urllib3/urllib3/issues/3267>__)
  • Fixed handling of new error message from OpenSSL 3.2.0 when configuring an HTTP proxy as HTTPS (#&#8203;3268 <https://github.com/urllib3/urllib3/issues/3268>__)
  • Fixed TLS 1.3 post-handshake auth when the server certificate validation is disabled (#&#8203;3325 <https://github.com/urllib3/urllib3/issues/3325>__)
  • Note for downstream distributors: To run integration tests, you now need to run the tests a second
    time with the --integration pytest flag. (#&#8203;3181 <https://github.com/urllib3/urllib3/issues/3181>__)

v2.1.0

Compare Source

==================

Read the v2 migration guide <https://urllib3.readthedocs.io/en/latest/v2-migration-guide.html>__ for help upgrading to the latest version of urllib3.

Removals

  • Removed support for the deprecated urllib3[secure] extra. (#&#8203;2680 <https://github.com/urllib3/urllib3/issues/2680>__)
  • Removed support for the deprecated SecureTransport TLS implementation. (#&#8203;2681 <https://github.com/urllib3/urllib3/issues/2681>__)
  • Removed support for the end-of-life Python 3.7. (#&#8203;3143 <https://github.com/urllib3/urllib3/issues/3143>__)

Bugfixes

  • Allowed loading CA certificates from memory for proxies. (#&#8203;3065 <https://github.com/urllib3/urllib3/issues/3065>__)
  • Fixed decoding Gzip-encoded responses which specified x-gzip content-encoding. (#&#8203;3174 <https://github.com/urllib3/urllib3/issues/3174>__)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Third-party library dependencies. label Nov 13, 2023
@renovate renovate bot enabled auto-merge (rebase) November 13, 2023 13:24
@renovate renovate bot force-pushed the renovate/urllib3-2.x branch 6 times, most recently from 19baaf0 to 5986d65 Compare November 17, 2023 09:10
@nijel
Copy link
Member

nijel commented Nov 17, 2023

This is (again) incompatible with botocore, see boto/botocore#2926

@renovate renovate bot force-pushed the renovate/urllib3-2.x branch 14 times, most recently from 0c0bade to 9ffa3d7 Compare November 23, 2023 12:25
@renovate renovate bot force-pushed the renovate/urllib3-2.x branch 6 times, most recently from 0494f8d to bfe2d1c Compare November 29, 2023 16:39
@ArielPrevu3D
Copy link

ArielPrevu3D commented Jan 30, 2024

There's a breaking change in urllib 2.2.0.

https://github.com/urllib3/urllib3/blame/2.2.0/src/urllib3/connectionpool.py#L754

They convert the headers to HTTPHeaderDict, which does not support bytes as values. The values are bytes because botocore encodes the headers when it prepares awsrequest.

This change raises an exception when urllib calls conn.request and the 'Expect' header is looked up by botocore.

  File "/usr/local/lib/python3.8/dist-packages/botocore/httpsession.py", line 464, in send
    urllib_response = conn.urlopen(
  File "/usr/local/lib/python3.8/dist-packages/urllib3/connectionpool.py", line 793, in urlopen
    response = self._make_request(
  File "/usr/local/lib/python3.8/dist-packages/urllib3/connectionpool.py", line 496, in _make_request
    conn.request(
  File "/usr/local/lib/python3.8/dist-packages/botocore/awsrequest.py", line 91, in request
    if headers.get('Expect', b'') == b'100-continue':
  File "/usr/lib/python3.8/_collections_abc.py", line 660, in get
    return self[key]
  File "/usr/local/lib/python3.8/dist-packages/urllib3/_collections.py", line 261, in __getitem__
    return ", ".join(val[1:])

@renovate renovate bot force-pushed the renovate/urllib3-2.x branch 4 times, most recently from 75a4f53 to 422f642 Compare February 2, 2024 00:55
@renovate renovate bot force-pushed the renovate/urllib3-2.x branch 18 times, most recently from e060e8d to 2a87662 Compare February 15, 2024 16:53
@nijel
Copy link
Member

nijel commented Feb 15, 2024

Closing as boto3 breakage seems to be caused by urllib3 actually: urllib3/urllib3#3343

@nijel nijel closed this Feb 15, 2024
auto-merge was automatically disabled February 15, 2024 18:12

Pull request was closed

Copy link
Contributor Author

renovate bot commented Feb 15, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (==2.2.0). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/urllib3-2.x branch February 15, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Third-party library dependencies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants