Add Authereum provider #82
Conversation
miguelmota
force-pushed
the
authereum
branch
from
d749806
to
16ae714
Compare
|
Looking good, something wrong with the build, going to check it out |
miguelmota
force-pushed
the
authereum
branch
2 times, most recently
from
421a2b1
to
c72cb1b
Compare
|
Regarding the build, looks like it's running out of memory. You can use |
|
BTW @miguelmota I just tested the example locally with Authereum and I got the following error: |
|
Also I tested the production build for the example locally too and disabling I also noticed that the app bundle size increased considerably with the You should look into your dependencies and most importantly your webpack config because otherwise you will have to ask all apps to disable |
|
@pedrouid yeah you're right it's absurdly large. We'll work on removing dependencies to get it to a normal size. Agree that disabling sourcemaps shouldn't be required because of this. Thanks for trying it out and providing suggestions and I'll get back to you when it's improved |
miguelmota
force-pushed
the
authereum
branch
2 times, most recently
from
86d2e31
to
32ea7b5
Compare
|
Deployment looks good now with removed dependencies |
|
Nice 👍 However I just tested again and I still get the missing |
|
I'll test it out; what browser were you using? and were you using incognito mode? |
miguelmota
force-pushed
the
authereum
branch
from
32ea7b5
to
6ff8abf
Compare
|
I wonder if you were using an old version because the latest version doesn't use localStorage at all. You should try pulling the latest changes and wiping node_modules before trying it again |
|
Hi @miguelmota, I'm happy to merge this PR but I keep getting this issue. I cloned again from authereum/web3connect repo and I got the same with localstorage. The version installed was 0.0.4-beta.8.
Can you try it yourself on your machine? Fresh clone to try to replicate it. |
|
@pedrouid ah I see now, it must be because your browser has cookies and localStorage disabled in the settings. I'll try to figure out a way to work around that. |
|
Hey @pedrouid I'm curious to how you're able to interact with other providers that rely on localStorage (ie like Portis) with the recommended browser setting turned off nau We aren't able to maintain sessions or store the ephemeral keys if there's no way to store them in the browser by blocking all site data. The best we can do is to alert the user to enable site data to access the provider (like portis does) |
|
@pedrouid the authereum provider should no longer crash like that and it displays an error toastr if persistent storage is not available which is required. Many other providers won't also work with 3rd party storage disabled which is default in brave Related web3/web3.js#3031 |
|
Hey @pedrouid is there anything we can do to help get this merged? The error you were seeing no longer exists (tested on brave with shield enabled). Would really like to start promoting web3connect to dapps but first need it merged! |
|
Hey @miguelmota, I just resolved merge conflicts and run the example again but now Im getting a compile error for some reason.
Any idea what this might be? |
|
@pedrouid thanks for reporting. On macOS some files seem to be lowercased in the dist directory although the source files are capitalized. Debugging issue.. |
|
@miguelmota I'm trying to test the Authereum integration and I'm getting the following error:
|
|
@crisgarner I filed an issue with the dependency provider causing the error blocknative/notify#22 Might need to find a workaround if the issue on their is not resolve soon enough |
miguelmota
force-pushed
the
authereum
branch
2 times, most recently
from
77623d2
to
87c23ec
Compare
miguelmota
force-pushed
the
authereum
branch
6 times, most recently
from
210ba6f
to
583c0c4
Compare
|
@pedrouid @crisgarner thanks for the patience; the dependency issues have been resolved and the latest build is working |
|
Tested and merged @miguelmota 👍 |
Add Authereum web3 provider