Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handshake canary metric #5671

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Conversation

ganchoradkov
Copy link
Member

@ganchoradkov ganchoradkov commented Feb 28, 2025

Description

Fixing a degration in canary handshake metrics after merging #5654 which caused handshake to be 0ms because socket wasn't actually started

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

metrics chart showing correct values

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@arein arein added the accepted label Feb 28, 2025
@ganchoradkov ganchoradkov marked this pull request as ready for review February 28, 2025 08:00
Copy link
Member

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@ganchoradkov ganchoradkov merged commit c3a3552 into v2.0 Mar 7, 2025
5 checks passed
@ganchoradkov ganchoradkov deleted the fix/canary-handshake-metric branch March 7, 2025 05:46
@ganchoradkov ganchoradkov mentioned this pull request Mar 12, 2025
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants