Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: repo cleanup #5611

Merged
merged 3 commits into from
Jan 27, 2025
Merged

chore: repo cleanup #5611

merged 3 commits into from
Jan 27, 2025

Conversation

ganchoradkov
Copy link
Member

@ganchoradkov ganchoradkov commented Jan 24, 2025

Description

Overtime the package-lock was getting bloated with out of sync and redudant dependencies and this PR fixes that.

  • Resynced the depps around the repo
  • Removed web3wallet from the workspaces and pr checks
  • Updated relay-auth to latest
  • Removed old unused test helper from sign-client

canary 2.17.5-canary-88adb04

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

tests, canary

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@arein arein added the accepted label Jan 24, 2025
@ganchoradkov ganchoradkov marked this pull request as ready for review January 24, 2025 10:06
Copy link
Contributor

@Cali93 Cali93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍


## web3wallet dependencies since its deprecated
packages/web3wallet/package-lock.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this do anything after the file's already been tracked?

it doesn't AFAIR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no tracked package-lock.json for web3wallet at the moment and this ignore is preemptive

@ganchoradkov ganchoradkov merged commit 2c3a0ca into v2.0 Jan 27, 2025
8 checks passed
@ganchoradkov ganchoradkov deleted the chore/repo-cleanup branch January 27, 2025 09:20
@ganchoradkov ganchoradkov mentioned this pull request Jan 28, 2025
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants