Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replaces stablelib with noble libs #5583

Merged
merged 8 commits into from
Jan 23, 2025

Conversation

ganchoradkov
Copy link
Member

@ganchoradkov ganchoradkov commented Jan 8, 2025

Description

Continuation of WalletConnect/walletconnect-utils#216 that is based on #5333 due to conflicts in the initial PR

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

tests
canary - 2.17.3-canary-nbl-1
reown-com/web-examples#800

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

Sorry, something went wrong.

@arein arein added the accepted label Jan 8, 2025
@ganchoradkov ganchoradkov marked this pull request as ready for review January 8, 2025 14:57
Copy link
Contributor

@devceline devceline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, has a local version of this worked with deployed production apps?

@ganchoradkov
Copy link
Member Author

ganchoradkov commented Jan 16, 2025

Code looks good to me, has a local version of this worked with deployed production apps?

yes, linked here reown-com/web-examples#800

Copy link
Contributor

@Cali93 Cali93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great to see the tests for interop

ganchoradkov and others added 4 commits January 17, 2025 11:55
…alletConnect/walletconnect-monorepo into refactor/replace-stablelibs-with-noble
# Conflicts:
#	packages/utils/package.json
@ganchoradkov ganchoradkov merged commit cb1d068 into v2.0 Jan 23, 2025
9 checks passed
@ganchoradkov ganchoradkov deleted the refactor/replace-stablelibs-with-noble branch January 23, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants