-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replaces stablelib with noble libs #5583
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, has a local version of this worked with deployed production apps?
yes, linked here reown-com/web-examples#800 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great to see the tests for interop
…alletConnect/walletconnect-monorepo into refactor/replace-stablelibs-with-noble
# Conflicts: # packages/utils/package.json
Description
Continuation of WalletConnect/walletconnect-utils#216 that is based on #5333 due to conflicts in the initial PR
Type of change
How has this been tested?
tests
canary -
2.17.3-canary-nbl-1
reown-com/web-examples#800
Checklist
Additional Information (Optional)
Please include any additional information that may be useful for the reviewer.