Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix example so that attachShadow does not throw an exception #632

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

dylanb
Copy link

@dylanb dylanb commented Mar 24, 2017

An unordered list <ul> is one of the elements that does not allow attachShadow() to be called. The example tries to call attachShadow() on the <ul>. This commit fixes this problem.

@hayatoito
Copy link
Contributor

hayatoito commented Mar 27, 2017

Thanks. However, it looks that this example needs more fix because the shadow host's children are <li>. I am afraid that it does not make sense to use <li> here if we do not use <ul> as a shadow host..

And the HTML Standard does not guarantee that <ul><slot></slot></ul> work at all. Even if <li> is assigned to a slot, we can not say that <ul> and <li> are in parent-child relationship here. This issue is still in the air.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants