Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service_account.yaml with proper end statement placement #1002

Merged
merged 1 commit into from
May 8, 2024

Conversation

tylerturk
Copy link
Contributor

The prior configuration allowed the generation of an empty service account yaml file with indented labels or annotations.

image

The prior configuration allowed the generation of an empty service account yaml file with indented labels or annotations.
Copy link
Contributor

@Haleygo Haleygo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Haleygo Haleygo merged commit c272174 into VictoriaMetrics:master May 8, 2024
6 of 8 checks passed
@Haleygo
Copy link
Contributor

Haleygo commented May 8, 2024

Thanks for the fix!

Haleygo added a commit that referenced this pull request May 8, 2024
@Haleygo Haleygo mentioned this pull request May 8, 2024
Haleygo added a commit that referenced this pull request May 10, 2024
Haleygo added a commit that referenced this pull request May 10, 2024
* make up changelogs for:
#1002,
#995

* follow up dfe967d

* make gen-docs

* prepare release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants