fix(dart_frog_cli): report daemon missing parameters #1050
Merged
+339
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiotrFLEURY
requested review from
felangel,
renancaraujo,
wolfenrain,
erickzanardo and
alestiago
as code owners
PiotrFLEURY
force-pushed
the
fix/daemon_missing_parameters_report
branch
from
30c31d6 to
b26b4dd
Compare
PiotrFLEURY
force-pushed
the
fix/daemon_missing_parameters_report
branch
from
b26b4dd to
0d2c145
Compare
|
Thanks for the review @renancaraujo I just pushed the suggested modification with some bonus tests for the getParam method ✨ Feel free to ask for any new change |
erickzanardo
previously approved these changes
Sep 18, 2023
renancaraujo
previously approved these changes
Sep 18, 2023
alestiago
previously approved these changes
Sep 18, 2023
renancaraujo
dismissed stale reviews from alestiago, erickzanardo, and themself
via
5797f1f
Co-authored-by: Alejandro Santiago <dev@alestiago.com>
renancaraujo
approved these changes
Sep 18, 2023
alestiago
approved these changes
Sep 18, 2023
erickzanardo
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Fix #913
dart_frog_cliDaemon wil now report missing parameters fordev_serverandroute_configurationdomainsType of Change