fix: Add appropriate response headers to SPA entry point HTML response #6992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
@zapplebee is attempting to deploy a commit to the unleash-team Team on Vercel. A member of the Team first needs to authorize it. |
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| @@ -201,6 +201,7 @@ export default async function getApp( | |||
| } | |||
|
|
|||
| app.get(`${baseUriPath}`, (req, res) => { | |||
| res.set('Content-Type', 'text/html'); | |||
There was a problem hiding this comment.
❌ Getting worse: Complex Method
getApp increases in cyclomatic complexity from 23 to 25, threshold = 9
zapplebee
changed the title
chriswk
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Current state, when returning the HTML entry point from the server, there are no headers attached. We encountered an issue with a deployment and this had an impact for us.
A brief description:
Content-Typeheader. This cache was very sticky.This PR does a few things.
Content-Type: text/html).Cache-Control: no-cache) and returns a 404. This will prevent misses from getting cached.Closes #
No open issue.
Important files
Discussion points
To me, there doesn't seem to be a lot of test infra on serving the SPA application. If that is an error, please indicate where that is and an appropriate test can be added.