Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove context field utility #196

Merged
merged 2 commits into from
Feb 5, 2024
Merged

feat: remove context field utility #196

merged 2 commits into from
Feb 5, 2024
+72 −18

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Feb 5, 2024 •
edited
Loading

About the changes

Followup on this PR: #192

Details:

  • utility method for removing single context field
  • extracted shared update toggles between updateContext and single field set/remove methods
  • setting and removing context field mirror non promise based interface due to backwards compatibility
  • utility type for finding defined fields
  • updated README about the new utility method

Important files

Discussion points

@kwasniew kwasniew merged commit 5ab4eab into main Feb 5, 2024
3 checks passed
@kwasniew kwasniew deleted the remove-context-field branch February 5, 2024 15:57
@kwasniew kwasniew mentioned this pull request Feb 5, 2024
Closed
@lwih lwih mentioned this pull request Jun 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunogois nunogois

@sighphyre sighphyre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kwasniew @nunogois