Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add curent time to context defined fields #195

Merged
merged 4 commits into from
Jan 15, 2024
Merged

fix: add curent time to context defined fields #195

merged 4 commits into from
Jan 15, 2024
+15 −1

Conversation

sjaanus
Copy link
Contributor

@sjaanus sjaanus commented Jan 15, 2024 •
edited
Loading

Solves #194

sighphyre
sighphyre reviewed Jan 15, 2024
View reviewed changes
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do in practise? Can we get a test asserting the behaviour does what it says (dunno what that behaviour is from looking at this change)

@sjaanus
Add test
Loading
Loading status checks…
9db1fd2
@sjaanus
Fix
d7c57e8
@sjaanus
Copy link
Contributor Author

sjaanus commented Jan 15, 2024

What does this do in practise? Can we get a test asserting the behaviour does what it says (dunno what that behaviour is from looking at this change)

Yep, somehow test did not get into commit.

@sjaanus sjaanus requested a review from sighphyre January 15, 2024 11:03
sighphyre
sighphyre approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! That looks nicer!

@sjaanus sjaanus merged commit 9e33d70 into main Jan 15, 2024
@sjaanus sjaanus deleted the current-time-context branch January 15, 2024 13:43
This was referenced Jan 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sighphyre sighphyre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sjaanus @sighphyre