feat: automatically generated instanceId #637
Merged
+10
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure it needs a major version because the code will still work if you pass an object with an |
It matters for TypeScript, sadly (actually strongly mixed feelings?). I thought the same thing so I went and checked and yes the compiler does complain |
|
:old-man-yells-at-typescript: |
nunogois
added a commit
that referenced
this pull request
Jul 10, 2024
nunogois
added a commit
that referenced
this pull request
Jul 10, 2024
|
What about Unleash-API-compatible providers like Gitlab Feature Flags, that do require an |
nunogois
added a commit
that referenced
this pull request
Jul 15, 2024
renovate bot
referenced
this pull request
in Unleash/unleash
Sep 9, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [unleash-client](https://redirect.github.com/Unleash/unleash-client-node) | [`5.5.5` -> `5.6.1`](https://renovatebot.com/diffs/npm/unleash-client/5.5.5/5.6.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Unleash/unleash-client-node (unleash-client)</summary> ### [`v5.6.1`](https://redirect.github.com/Unleash/unleash-client-node/releases/tag/v5.6.1) [Compare Source](https://redirect.github.com/Unleash/unleash-client-node/compare/v5.6.0...v5.6.1) #### What's Changed - Revert "feat: automatically generated instanceId ([#​637](https://redirect.github.com/Unleash/unleash-client-node/issues/637))" by [@​nunogois](https://redirect.github.com/nunogois) in [https://github.com/Unleash/unleash-client-node/pull/640](https://redirect.github.com/Unleash/unleash-client-node/pull/640) **Full Changelog**: Unleash/unleash-client-node@v5.6.0...v5.6.1 ### [`v5.6.0`](https://redirect.github.com/Unleash/unleash-client-node/releases/tag/v5.6.0) [Compare Source](https://redirect.github.com/Unleash/unleash-client-node/compare/v5.5.5...v5.6.0) #### What's Changed - chore(deps): update dependency typescript to v5.5.2 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/Unleash/unleash-client-node/pull/631](https://redirect.github.com/Unleash/unleash-client-node/pull/631) - chore(deps): update unleash/.github action to v1.2.0 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/Unleash/unleash-client-node/pull/632](https://redirect.github.com/Unleash/unleash-client-node/pull/632) - feat: automatically generated instanceId by [@​nunogois](https://redirect.github.com/nunogois) in [https://github.com/Unleash/unleash-client-node/pull/637](https://redirect.github.com/Unleash/unleash-client-node/pull/637) - feat: http and https proxy support by [@​kwasniew](https://redirect.github.com/kwasniew) in [https://github.com/Unleash/unleash-client-node/pull/638](https://redirect.github.com/Unleash/unleash-client-node/pull/638) **Full Changelog**: Unleash/unleash-client-node@v5.5.5...v5.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 7pm every weekday,before 5am every weekday" in timezone Europe/Madrid, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/Unleash/unleash). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-2397/make-instance-id-autogenned-node
This makes
instanceIdan automatically generated property, instead of being set by the user.Similar to Unleash/unleash-client-ruby#179
Similar to Unleash/unleash-client-dotnet#226