Rename internal-first sort strategy to external-last

TypeStrong · Oct 28, 2023 · 325233c · 325233c
1 parent 02a14c0
commit 325233c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/lib/utils/sort.ts b/src/lib/utils/sort.ts
@@ -19,7 +19,7 @@ export const SORT_STRATEGIES = [
     "visibility",
     "required-first",
     "kind",
-    "internal-first",
+    "external-last",
 ] as const;
 
 export type SortStrategy = (typeof SORT_STRATEGIES)[number];
@@ -152,7 +152,7 @@ const sorts: Record<
     kind(a, b, { kindSortOrder }) {
         return kindSortOrder.indexOf(a.kind) < kindSortOrder.indexOf(b.kind);
     },
-    "internal-first"(a, b) {
+    "external-last"(a, b) {
         return !a.flags.isExternal && b.flags.isExternal;
     },
 };

diff --git a/src/test/utils/sort.test.ts b/src/test/utils/sort.test.ts
@@ -209,7 +209,7 @@ describe("Sort", () => {
         );
     });
 
-    it("Should sort by internal first", () => {
+    it("Should sort by external last", () => {
         const arr = [
             new DeclarationReflection("a", ReflectionKind.Function),
             new DeclarationReflection("b", ReflectionKind.Function),
@@ -219,7 +219,7 @@ describe("Sort", () => {
         arr[1].setFlag(ReflectionFlag.External, false);
         arr[2].setFlag(ReflectionFlag.External, true);
 
-        sortReflections(arr, ["internal-first"]);
+        sortReflections(arr, ["external-last"]);
         equal(
             arr.map((r) => r.name),
             ["b", "a", "c"],