Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added support for named start #768

Merged
merged 13 commits into from
Oct 14, 2022
Merged

feat: added support for named start #768

merged 13 commits into from
Oct 14, 2022

Commits on Oct 14, 2022

  1. chore(stop): abstract instance getter to its own utility

    @vikaspotluri123 @daniellockyer
    vikaspotluri123 authored and daniellockyer committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    46a058c View commit details
    Browse the repository at this point in the history

  2. feat(start): add support for starting named instance 

    - ex: `ghost start myInstance`
- similar to `ghost stop myInstance`

- clean + dry up start tests a bit
- use `getInstance` util which was added in 9a7ddc2
    @vikaspotluri123 @daniellockyer
    vikaspotluri123 authored and daniellockyer committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    ef009ee View commit details
    Browse the repository at this point in the history

  3. chore(tests): dry up + clean up stop tests 

    refs 9a7ddc2 - made those tests pass, and majorly refactored how the tests are structured for dryer testing
    @vikaspotluri123 @daniellockyer
    vikaspotluri123 authored and daniellockyer committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    79b28df View commit details
    Browse the repository at this point in the history

  4. chore(consistancy): remove unnecessary assertions, update get-instanc… 

    …e function name
    @vikaspotluri123 @daniellockyer
    vikaspotluri123 authored and daniellockyer committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    75f8b9e View commit details
    Browse the repository at this point in the history

  5. fix merge conflicts

    @vikaspotluri123 @daniellockyer
    vikaspotluri123 authored and daniellockyer committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    f15883d View commit details
    Browse the repository at this point in the history

  6. refactor stopAll to use native for loop

    @vikaspotluri123 @daniellockyer
    vikaspotluri123 authored and daniellockyer committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    63736ce View commit details
    Browse the repository at this point in the history

  7. fix merge conflicts: the sql

    @vikaspotluri123 @daniellockyer
    vikaspotluri123 authored and daniellockyer committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    afe943e View commit details
    Browse the repository at this point in the history

  8. it's 2020 ya'll!

    @vikaspotluri123 @daniellockyer
    vikaspotluri123 authored and daniellockyer committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    9c5dfcf View commit details
    Browse the repository at this point in the history

  9. make stop and start have similar command parity

    @vikaspotluri123 @daniellockyer
    vikaspotluri123 authored and daniellockyer committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    c53b729 View commit details
    Browse the repository at this point in the history

  10. prefer skipInstanceCheck over more complex logic

    @vikaspotluri123 @daniellockyer
    vikaspotluri123 authored and daniellockyer committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    781d2ae View commit details
    Browse the repository at this point in the history

  11. fix tests

    @vikaspotluri123 @daniellockyer
    vikaspotluri123 authored and daniellockyer committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    b500797 View commit details
    Browse the repository at this point in the history

  12. use directory traversal in get-instance util

    @vikaspotluri123 @daniellockyer
    vikaspotluri123 authored and daniellockyer committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    087cf1e View commit details
    Browse the repository at this point in the history

  13. fixed linting

    @daniellockyer
    daniellockyer committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    f39c66c View commit details
    Browse the repository at this point in the history