Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added support for named start #768

Merged
merged 13 commits into from Oct 14, 2022
Merged

feat: added support for named start #768

merged 13 commits into from Oct 14, 2022

Conversation

vikaspotluri123
Copy link
Member

Adds functionality similar to the stop command - ghost start {name} now works as ghost stop {name} always has

I realized this wasn't a thing as I was testing #765, and given the Stop command already has this functionality, I figured it would be a 5 minute fix, but it turns out both the Start and Stop Command Unit tests aren't super dry, so I ended up going down the rabbit hole of drying up the tests. It might be easier to review commit by commit 😬

I know this coincides w/ the release of 1.9.0; I don't think it will make much of a difference if this gets released before or afterwards.

@coveralls
Copy link

coveralls commented Jul 28, 2018 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 593d851 on vikaspotluri123:feat/named-start into 77188ef on TryGhost:master.

acburdine
acburdine reviewed Jul 29, 2018
View reviewed changes
lib/commands/start.js Outdated Show resolved Hide resolved
lib/commands/stop.js Outdated Show resolved Hide resolved
@vikaspotluri123 vikaspotluri123 force-pushed the feat/named-start branch 2 times, most recently from 68f4241 to 9ddc1e1 Compare July 29, 2018 20:06
@vikaspotluri123
Copy link
Member Author

@acburdine everything's been fixed now 😄

@vikaspotluri123 vikaspotluri123 force-pushed the feat/named-start branch 2 times, most recently from a6829d4 to 593d851 Compare September 5, 2018 04:40
@vikaspotluri123
Copy link
Member Author

Rebased! 🙃

@vikaspotluri123
Copy link
Member Author

vikaspotluri123 commented Oct 10, 2020 •
edited

Couple things:

  • Do we want to add parity between stop, start, and update? There is a feature request for update --all, and we can add support for start --all as well.
  • Should get-instance be used / run in the System Class?

@github-actions
Copy link

github-actions bot commented May 3, 2021

Our bot has automatically marked this PR as stale because there has not been any activity here in some time. If we’ve failed to review your PR & you’re still interested in working on it, please let us know. Otherwise this PR will be closed shortly, but can always be reopened later. Thank you for understanding 🙂

@github-actions github-actions bot added the Stale label May 3, 2021
@github-actions github-actions bot closed this May 12, 2021
@vikaspotluri123 vikaspotluri123 changed the base branch from main to 1.x January 29, 2022 22:54
vikaspotluri123
vikaspotluri123 commented Jan 29, 2022
View reviewed changes
lib/commands/start.js
@@ -41,7 +48,7 @@ class StartCommand extends Command {
].join('\n'), 'yellow');
}

await this.runCommand(DoctorCommand, {categories: ['start'], ...argv, quiet: true});
await this.runCommand(DoctorCommand, {categories: ['start'], ...argv, quiet: true, skipInstanceCheck: true});
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add support for named update, I think we can get rid of this skipInstanceCheck flag, since it will be true in all places where the doctor command is run. Plus, start, stop, and update will have similar command structures!

@daniellockyer daniellockyer changed the base branch from 1.x to main May 18, 2022 13:22
@ErisDS
Copy link
Member

ErisDS commented Aug 30, 2022

Is there anything outstanding that prevents us from merging this PR? There may be more things we want to do, but if this change is valid and useful, let's get it in? 😄

@vikaspotluri123
Copy link
Member Author

Nothing on my side!

vikaspotluri123 and others added 5 commits October 14, 2022 10:38
@vikaspotluri123 @daniellockyer
chore(stop): abstract instance getter to its own utility
46a058c
@vikaspotluri123 @daniellockyer
feat(start): add support for starting named instance
ef009ee 
- ex: `ghost start myInstance`
- similar to `ghost stop myInstance`

- clean + dry up start tests a bit
- use `getInstance` util which was added in 9a7ddc2
@vikaspotluri123 @daniellockyer
chore(tests): dry up + clean up stop tests
79b28df 
refs 9a7ddc2 - made those tests pass, and majorly refactored how the tests are structured for dryer testing
@vikaspotluri123 @daniellockyer
chore(consistancy): remove unnecessary assertions, update get-instanc…
75f8b9e 
…e function name
@vikaspotluri123 @daniellockyer
fix merge conflicts
f15883d
@daniellockyer daniellockyer changed the title Feat: Add support for named start feat: added support for named start Oct 14, 2022
@daniellockyer daniellockyer merged commit 701b125 into TryGhost:main Oct 14, 2022
@vikaspotluri123 vikaspotluri123 deleted the feat/named-start branch October 14, 2022 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acburdine acburdine acburdine left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vikaspotluri123 @coveralls @ErisDS @acburdine @daniellockyer