Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pr-worthy.yml #168

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Update pr-worthy.yml #168

merged 3 commits into from
Jun 5, 2023

Conversation

Spongman
Copy link
Contributor

@Spongman Spongman commented Jun 3, 2023

use tj-actions/changed-files to calculate which languages require build/test

use tj-actions/changed-files to calculate which languages require build/test
@novusnota
Copy link
Contributor

@Spongman great addition!

But you probably have to add:

uses: actions/checkout@v3
with:
  fetch-depth: 0  # to retrieve all commits
uses: tj-actions/changed-files@v36
with:
  since-last-remote-commit: true  # to make it work against the most recent additions to master

And I'd also suggest adding the branches: to the pull_request: section on top to make checks run when merging into the master branch and not for everything:

pull_request:
  branches: [master]  # only run the workflow on merging into the master branch

@Spongman
Copy link
Contributor Author

Spongman commented Jun 4, 2023

are you sure since_last_remote_commit: true is necessary?

Defaults to the last non merge commit on the target branch for pull request events

set `fetch-depth: 0` and `branches: [master]`
@novusnota
Copy link
Contributor

@Spongman I'm thinking yes, as otherwise it compares the latest state of your PR with the previous commit on your PR, not with the latest remote as a whole. See: issue and the answer

set `since_last_remote_commit: true`
@Spongman
Copy link
Contributor Author

Spongman commented Jun 4, 2023

ok, sounds good. committed.

@novusnota
Copy link
Contributor

@vhladko hey, could you please review and/or merge this? :)

@vhladko
Copy link
Collaborator

vhladko commented Jun 5, 2023

Lgtm, merged :)

@vhladko vhladko merged commit 17eb615 into ThePrimeagen:master Jun 5, 2023
@Spongman Spongman deleted the patch-4 branch June 5, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants