Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps!: migrate plugins to genkit 0.9.0 #157

Merged
merged 25 commits into from
Nov 15, 2024
Merged

deps!: migrate plugins to genkit 0.9.0 #157

merged 25 commits into from
Nov 15, 2024

Conversation

EPMatt
Copy link
Contributor

@EPMatt EPMatt commented Nov 14, 2024

Copied from #155.

Before you submit a pull request, please make sure you have read and understood the contribution guidelines and the code of conduct.

This pull request is related to:

  • A bug
  • A new feature
  • Documentation
  • Other: The next version of Genkit (0.9) has many breaking changes for the plugin API. This PR migrates some 3P plugins to 0.9.

I have checked the following:

  • I have read and understood the contribution guidelines and the code of conduct;
  • I have added new tests (for bug fixes/features);
  • I have added/updated the documentation (for bug fixes / features).

Description:
Migrate several 3P plugins to 0.9
Related issues:
firebase/genkit#1088

Sorry, something went wrong.

cabljac and others added 23 commits November 1, 2024 13:40

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* feat: add embedding to cohere example

* fix: make mistral embeddingTypes optional

* feat: add embedding to openai example
* chore(*): keep RC dependency compatible with stable release

* fix(cohere): remove direct import of zod
* chore: fix RC bump deps (#5)

* chore(*): keep RC dependency compatible with stable release

* fix(cohere): remove direct import of zod

* fix(groq): amend model ref names
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Pavel Jbanov <pavelgj@gmail.com>
@EPMatt
Copy link
Contributor Author

EPMatt commented Nov 14, 2024

@all-contributors add @cabljac as code, tests and documentation contributor

Copy link
Contributor

@EPMatt

I've put up a pull request to add @cabljac! 🎉

@cabljac
Copy link
Contributor

cabljac commented Nov 14, 2024

hm seems like groq tests are failing, want me to go in and fix?

@EPMatt
Copy link
Contributor Author

EPMatt commented Nov 14, 2024

@cabljac didn't see your comment - I was already on it. Thank you again for your contribution! 🔥

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
45.7% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Collaborator

@xavidop xavidop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do to a regression failure, you will need to modify the function that transforms the GenkitRequest into OpenAI/Claude/Groq/etc Request. The way we were detecting the format json/text has changed and it is no longer under: request.output?.format it is now under: request.output?.contentType check my plugin for reference:https://github.com/xavidop/genkitx-github/blob/8d9afd06416e5138708653be51ec3924d983ef12/src/github_llms.ts#L727

@EPMatt
Copy link
Contributor Author

EPMatt commented Nov 15, 2024

@xavidop thanks for sharing! Would you be up to push your suggested changes here? It looks like it could be a quick task, as you also already implemented the regression fix in your plugins.

@xavidop
Copy link
Collaborator

xavidop commented Nov 15, 2024

@xavidop thanks for sharing! Would you be up to push your suggested changes here? It looks like it could be a quick task, as you also already implemented the regression fix in your plugins.

@EPMatt sure thing, should I commit in this branch or create a new branch + another PR?

@EPMatt
Copy link
Contributor Author

EPMatt commented Nov 15, 2024

@xavidop amazing, please make a new PR based on top of this.
Given the urgency of the update, I'm gonna to bypass sonarcloud and merge this with a note to plugin maintainers to improve test coverage in the future. It looks like some plugins even don't have tests configured.

Thanks to all the people involved in this PR for contributing!

@EPMatt EPMatt merged commit 7051a59 into main Nov 15, 2024
1 of 2 checks passed
@EPMatt EPMatt deleted the pr/cabljac/155 branch November 15, 2024 13:11
@xavidop
Copy link
Collaborator

xavidop commented Nov 15, 2024

@EPMatt #161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants