-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps!: migrate plugins to genkit 0.9.0 #157
Conversation
* feat: add embedding to cohere example * fix: make mistral embeddingTypes optional * feat: add embedding to openai example
* chore(*): keep RC dependency compatible with stable release * fix(cohere): remove direct import of zod
* chore: fix RC bump deps (#5) * chore(*): keep RC dependency compatible with stable release * fix(cohere): remove direct import of zod * fix(groq): amend model ref names
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Pavel Jbanov <pavelgj@gmail.com>
@all-contributors add @cabljac as code, tests and documentation contributor |
I've put up a pull request to add @cabljac! 🎉 |
hm seems like groq tests are failing, want me to go in and fix? |
@cabljac didn't see your comment - I was already on it. Thank you again for your contribution! 🔥 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do to a regression failure, you will need to modify the function that transforms the GenkitRequest into OpenAI/Claude/Groq/etc Request. The way we were detecting the format json/text has changed and it is no longer under: request.output?.format
it is now under: request.output?.contentType
check my plugin for reference:https://github.com/xavidop/genkitx-github/blob/8d9afd06416e5138708653be51ec3924d983ef12/src/github_llms.ts#L727
@xavidop thanks for sharing! Would you be up to push your suggested changes here? It looks like it could be a quick task, as you also already implemented the regression fix in your plugins. |
@xavidop amazing, please make a new PR based on top of this. Thanks to all the people involved in this PR for contributing! |
Copied from #155.
Before you submit a pull request, please make sure you have read and understood the contribution guidelines and the code of conduct.
This pull request is related to:
next
version of Genkit (0.9) has many breaking changes for the plugin API. This PR migrates some 3P plugins to0.9
.I have checked the following:
Description:
Migrate several 3P plugins to
0.9
Related issues:
firebase/genkit#1088