Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-height table repopulate fix #4992

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Auto-height table repopulate fix #4992

merged 3 commits into from
Sep 13, 2024

Conversation

darrenburns
Copy link
Member

Fixes #4928, which was broken in commit 2336757

Verified

This commit was signed with the committer’s verified signature.
mikededo Miquel de Domingo i Giralt

Verified

This commit was signed with the committer’s verified signature.
mikededo Miquel de Domingo i Giralt
…uto-fix

Verified

This commit was signed with the committer’s verified signature.
mikededo Miquel de Domingo i Giralt
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what the original change was "fixing" ?

@darrenburns
Copy link
Member Author

The comment in the commit of the original change described the previous cache clear as "superfluous", which is understandable as it took this long for us to realise that wasn't the case!

@darrenburns darrenburns merged commit 769c7f6 into main Sep 13, 2024
20 checks passed
@darrenburns darrenburns deleted the datatable-auto-fix branch September 13, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clearing and adding data to DataTable without worker will cause it to sometime not display its content.
2 participants